Closed
Conversation
Collaborator
|
@ef4 / @asakusuma r? |
Collaborator
|
@stefanpenner lgtm, but isn't this the same general approach as #93? And if so, does the same deduping question need to be answered? |
Contributor
Author
|
@asakusuma I somehow missed that PR. I feel like deduping is a pandora's box and requires a different PR/conversation all together. /cc @stefanpenner |
Collaborator
|
@twokul I agree that this is a separate issue, but I defer to @stefanpenner since he raised the issue in the first place. |
Contributor
Author
|
@asakusuma 👍 👌 |
Collaborator
|
@twokul did you do the deeper investigation we discussed in-person. We discovered that basically the scenario described most likely does not work in the first case, this merely prevents it from exploding but does not address the underlying issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the child addons (the ones that consume
ember-browserify) start breaking after upgrading to2.7.0. This fixes failures.