Ignore browser field when running with Fastboot#115
Ignore browser field when running with Fastboot#115gabrielgrant wants to merge 1 commit intoef4:masterfrom
browser field when running with Fastboot#115Conversation
| basedir: this._inputStaging, | ||
| debug: this.enableSourcemap | ||
| debug: this.enableSourcemap, | ||
| browserField: !process.env.EMBER_CLI_FASTBOOT |
There was a problem hiding this comment.
this mode isn't a thing anymore, we likely need to produce 2 bundles. One for fastboot and one without.
Slightly more involved, but will solve this nicely!
There was a problem hiding this comment.
Sorry, not sure I understand...which mode isn't a thing anymore?
...and sorry I haven't had a chance to get back to tracking down the original error I was seeing when I first implemented this, we pushed off our fastboot deploy :/
There was a problem hiding this comment.
EMBER_CLI_FASTBOOT is not a thing in fastboot 1.0, there is only 1 build now, now two (fastboot + non-fastboot)
There was a problem hiding this comment.
Ah, interesting. Like I said, haven't been following development too closely of late. According to https://ember-fastboot.com/docs/user-guide#packaging-your-app there's still an app-fastboot.js asset generated at build time. I'm not sure I follow what ends up in that bundle, though. Is it just the fastbootDependencies defined in your app's package.json? Could this still be used somehow to override the browser version of a package with the non-browser build?
(or are you saying that doc is out of date, and that file actually no longer gets created?)
2 participants
Fixes #114
This seems to pull in the correct (non-browser) code under Fastboot, but causes an error
TypeError: _ObjectImportedWithRequire.default is not a constructor. Shouldn't be merged until I've sorted out why that's happening.