Conversation
duncdrum
left a comment
There was a problem hiding this comment.
Lots of good stuff. Thanks @DrRataplan
However I would
- reuse the test image from the container setup, when running app tests.
- Execture TP, Serafin, and Workbench in parallel instead of sequentially for better and more targeted feedback. Right now if Serafin fails, workbench never executes.
- the
SIGSEGVerror is a regression and should be fixed and reproduced in the components repo. - Tests need to use
-b firefoxas it prevents the electron crash
0a6c143 to
64e28be
Compare
duncdrum
left a comment
There was a problem hiding this comment.
needs a bit more work:
- the test exclusions need to go, these test pass (outside of electron)
- we need to streamline the container generation and reuse,
- make sure all actions scripts are on latest version.
I ll add to the PR later
f833af6 to
6c8d209
Compare
|
ok I m going to rebase to bring the latest hotness from |
These fail with a SIGSEGV from Cypress
- run test in firefox to avoid SIGSEGV electron crash
- Upgrade actions/checkout to v6 for improved performance. - Introduce separate jobs for running Cypress tests on individual demo apps. - Remove deprecated run-tests-for-apps.yml workflow file.
- use correct container name.
during releases - Rename workflows. - Introduce separate jobs for testing and pushing Jinks images. - Add conditional steps for pull requests and main branch pushes. - Remove deprecated docker-publish.yml workflow file.
duncdrum
left a comment
There was a problem hiding this comment.
here goes: Test are running, no SIGSEGV the failures in tp-workbench and serafin are real.
jink-demo images (which are used during tei-publisher releases) are only deployed to the registry after all tests pass. So no test fixes no new image for a tei-publisher release
streamline the whole operation. We were generating apps and passing them around before, this makes more use of that, and the container we already build with these apps.
lots of refactoring to hopefully ensure things run smoothly during jinks releases
|
@DrRataplan can't request you as a reviewer but have a look if this does what you want. |
|
- Modify build workflow to trigger on all branches and version tags. - Add concurrency control for demo apps workflow. - Standardize job names and conditions for testing and pushing Jinks images. - Ensure proper execution flow for demo app generation and testing jobs.
|
but what about a roaster update?? |
These break too often, indicating they are not always executed before every commit. I hacked together a github CI flow that:
npm run teston itSure, reporting could be prettier. But we need automated tests.
Some notes:
Tests fail (to no surprise). But most of them succeed.
Some fail hard: the ones in browse.cy.js make Cypress error out with a SIGSERV. They need attention. I had to disable them for now.