Skip to content

Comments

Run Cypress tests for demo apps in CI#277

Draft
DrRataplan wants to merge 10 commits intomainfrom
tests
Draft

Run Cypress tests for demo apps in CI#277
DrRataplan wants to merge 10 commits intomainfrom
tests

Conversation

@DrRataplan
Copy link
Contributor

These break too often, indicating they are not always executed before every commit. I hacked together a github CI flow that:

  • Installs current Jinks in a new container
  • Generates the demo apps
  • For each app:
    • Download it using XST
    • NPM installs it
    • Runs npm run test on it

Sure, reporting could be prettier. But we need automated tests.

Some notes:

Tests fail (to no surprise). But most of them succeed.
Some fail hard: the ones in browse.cy.js make Cypress error out with a SIGSERV. They need attention. I had to disable them for now.

@DrRataplan DrRataplan requested a review from duncdrum February 18, 2026 09:46
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good stuff. Thanks @DrRataplan

However I would

  • reuse the test image from the container setup, when running app tests.
  • Execture TP, Serafin, and Workbench in parallel instead of sequentially for better and more targeted feedback. Right now if Serafin fails, workbench never executes.
  • the SIGSEGV error is a regression and should be fixed and reproduced in the components repo.
  • Tests need to use -b firefox as it prevents the electron crash

@DrRataplan DrRataplan force-pushed the tests branch 5 times, most recently from 0a6c143 to 64e28be Compare February 18, 2026 17:14
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a bit more work:

  • the test exclusions need to go, these test pass (outside of electron)
  • we need to streamline the container generation and reuse,
  • make sure all actions scripts are on latest version.

I ll add to the PR later

@duncdrum duncdrum force-pushed the tests branch 6 times, most recently from f833af6 to 6c8d209 Compare February 19, 2026 16:19
@duncdrum
Copy link
Contributor

ok I m going to rebase to bring the latest hotness from main

DrRataplan and others added 7 commits February 19, 2026 17:36
These fail with a SIGSEGV from Cypress
- run test in firefox to avoid SIGSEGV electron crash
- Upgrade actions/checkout to v6 for improved performance.
- Introduce separate jobs for running Cypress tests on individual demo apps.
- Remove deprecated run-tests-for-apps.yml workflow file.
- use correct container name.
during releases

- Rename workflows.
- Introduce separate jobs for testing and pushing Jinks images.
- Add conditional steps for pull requests and main branch pushes.
- Remove deprecated docker-publish.yml workflow file.
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here goes: Test are running, no SIGSEGV the failures in tp-workbench and serafin are real.

jink-demo images (which are used during tei-publisher releases) are only deployed to the registry after all tests pass. So no test fixes no new image for a tei-publisher release

streamline the whole operation. We were generating apps and passing them around before, this makes more use of that, and the container we already build with these apps.

lots of refactoring to hopefully ensure things run smoothly during jinks releases

@duncdrum duncdrum dismissed their stale review February 19, 2026 17:26

its fixed

@duncdrum
Copy link
Contributor

@DrRataplan can't request you as a reviewer but have a look if this does what you want.

@duncdrum
Copy link
Contributor

  • 1 Failing test on tp-workbench looks like something we fixed for tp-app recently, the fix apparently needs to be ported to another profile.
  • two skipped specs in tp-serafin related to sidebar and navigation, did someone change stuff without adjusting tests?

- Modify build workflow to trigger on all branches and version tags.
- Add concurrency control for demo apps workflow.
- Standardize job names and conditions for testing and pushing Jinks images.
- Ensure proper execution flow for demo app generation and testing jobs.
@duncdrum
Copy link
Contributor

but what about a roaster update??

@duncdrum duncdrum marked this pull request as draft February 24, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants