Feat treeshaking: Centralize js dependency management by duncdrum · Pull Request #243 · eeditiones/jinks

duncdrum · 2026-01-13T16:54:55Z

Establishes a single source of truth for Node.js dependencies across jinks and generated applications.

Key Changes:

Created config/package.json as centralized registry for all generated-app dependencies
Updated all templates (17 files) to use $cdn map instead of hardcoded CDN URLs
Added sync and validation scripts with GitHub Action for automated dependency management
Configured Dependabot to monitor both root and config/package.json with versioning-strategy: increase
Removed duplicate dependency declarations from profile config.json files
Added config/package-lock.json required for Dependabot

Benefits:

resolved existing conflicting versions
updated a number of outdated jinks dependencies that were hardcoded into html templates
Automated dependency updates via Dependabot PRs
No version conflicts between jinks and generated apps
CDN URLs automatically use versions from package.json
Validation ensures dependency consistency

should be reviewed after #240 is merged

config/README.md

DrRataplan · 2026-01-14T08:39:32Z

config/README.md

+When jinks generates an application:
+
+1. `modules/generator.xql` loads `config/package.json`
+2. CDN URLs are pre-computed using `config:cdn-url()` function


are these parameterized? So load jinn-tap from http://localhost:5174, jinks from resources/scripts and pb-components from CDN

yes, but the current integration with examples: for autosuggestion via jinks.json needs addressing

config/README.md

profiles/ci/.gitlab-ci.tpl.yml

profiles/ci/.github/workflows/ci.tpl.yml

…d apps - Introduced `sync:dependencies` and `validate:dependencies` scripts in package.json. - Added GitHub Actions workflow for syncing shared dependencies from root package.json to config/package.json. - Updated dependabot.yml to monitor dependencies in both root and config directories.

- Added a function to build CDN URLs from the dependencies defined in package.json. - Updated API context to include CDN URLs for swagger-ui and other assets. - Modified HTML templates to conditionally load assets from CDN or fallback to default URLs based on availability.

…ons in package.json - Updated swagger-ui-dist to version 5.31.0. - Updated @jinntec/jinn-codemirror to version 1.18.2.

- Updated annotate.html to use Fore.js version 2.8.0. - Modified base.html and static/base.html to conditionally load Fore.js from CDN if available, with a fallback to the default URL.

- Added new dependencies: theme-toggles and @jinntec/jinntap to package.json. - Updated README.md to clarify CDN URL template usage and overrides. - Improved API and generator modules to dynamically build CDN URLs for all asset types. - Enhanced templates to utilize the new CDN mapping for loading assets conditionally. - Processed styles array to replace hardcoded CDN URLs with templated versions from package.json.

- Added checks for missing base URLs and ensured at least one asset type is defined. - Validated that all asset type templates contain the {{version}} placeholder, adding appropriate warnings.

- Added `versioning-strategy: increase` to the Dependabot configuration for better version management. - Introduced `package-lock.json` to ensure consistent dependency resolution for automated updates.

- Enhanced the configuration to support profile-specific version overrides in `config/package.json`. - Updated the `effective-version` function to check for overrides based on active profiles. - Modified the CDN URL generation to apply these overrides, ensuring the correct versions are used when building URLs. - Improved documentation in `README.md` to clarify the usage of overrides and their precedence. - Adjusted templates to utilize effective versions for dependencies, enhancing flexibility in version management.

- Updated README.md to emphasize the use of function call syntax. - Modified various HTML templates to implement the new syntax for CDN key access. review comment: jinks#243#discussion_r2689497823

…and failing links

…ndency management - Added permissions for write access to contents and pull requests. - Updated the checkout step to fetch the full history. - Changed the dependency sync command to use npm script. - Improved change detection logic for config/package.json. - Enhanced commit and push logic to handle branch determination for pull requests.

refactor sync yaml simplify logic

DrRataplan · 2026-01-16T09:43:28Z

profiles/annotate/templates/pages/annotate.html

        ],
        "script": {
-            "fore": "1.9.0",
+            "fore": "2.8.0",


this should come from the central config, right?

DrRataplan · 2026-01-16T09:44:12Z

profiles/base10/templates/error-page.html

+        [% if exists($cdn?('jinn-codemirror-bundle')) %]
+        <script type="module" src="[[ $cdn?('jinn-codemirror-bundle') ]]"></script>
+        [% else %]
        <script type="module" src="https://cdn.jsdelivr.net/npm/@jinntec/jinn-codemirror@1.17.0/dist/jinn-codemirror-bundle.js"></script>


can't we do this defaulting in the config.json? Also, this should be 1.18.2 because of that firefox bug

DrRataplan · 2026-01-16T09:46:50Z

profiles/jinntap/templates/editor.html

        <jinn-tap url="[[ $url ]]" name="[[ $context?doc?path ]]" schema="[[ $context?features?jinntap?schema ]]"
                  token="[[ jt:jwt-token() ]]" server="[[ $features?collab?server ]]" sidebar="#attributes-panel">
+            [% if exists($features?jinntap?version) and $features?jinntap?version != "dev" %]
+            <img slot="aside" class="logo" src="[[ $features?jinntap?cdn ]]@[[ $features?jinntap?version ]]/dist/jinntap-logo-128.png" alt="JinnTap"/>


why not always get this through the configuration?

duncdrum requested a review from DrRataplan January 13, 2026 16:55

DrRataplan reviewed Jan 14, 2026

View reviewed changes

config/README.md Show resolved Hide resolved

DrRataplan reviewed Jan 14, 2026

View reviewed changes

DrRataplan requested changes Jan 14, 2026

View reviewed changes

config/README.md Outdated Show resolved Hide resolved

profiles/ci/.gitlab-ci.tpl.yml Outdated Show resolved Hide resolved

profiles/ci/.github/workflows/ci.tpl.yml Outdated Show resolved Hide resolved

This was referenced Jan 14, 2026

Synchronize gitlab-ci.tpl.yml in CI profile with docker build instructions in gha workflow #246

Closed

simplify templating logic gha workflow template #247

Open

duncdrum added 10 commits January 15, 2026 09:23

chore(dependencies): update swagger-ui-dist and jinn-codemirror versi…

db4ffd2

…ons in package.json - Updated swagger-ui-dist to version 5.31.0. - Updated @jinntec/jinn-codemirror to version 1.18.2.

fix(templates): enhance CDN support for Fore.js in HTML templates

c06c110

- Updated annotate.html to use Fore.js version 2.8.0. - Modified base.html and static/base.html to conditionally load Fore.js from CDN if available, with a fallback to the default URL.

docs(config/README.md): add documentation for dependency management

78eefb1

fix(validate-dependencies): improve CDN configuration validation

242e3c2

- Added checks for missing base URLs and ensured at least one asset type is defined. - Validated that all asset type templates contain the {{version}} placeholder, adding appropriate warnings.

chore(dependabot): update configuration and add package-lock.json

099e292

- Added `versioning-strategy: increase` to the Dependabot configuration for better version management. - Introduced `package-lock.json` to ensure consistent dependency resolution for automated updates.

refactor: consistent use of function call syntax for accessing CDN map

cabc35c

- Updated README.md to emphasize the use of function call syntax. - Modified various HTML templates to implement the new syntax for CDN key access. review comment: jinks#243#discussion_r2689497823

duncdrum force-pushed the feat-treeshaking branch from 280e01a to cabc35c Compare January 15, 2026 08:24

wolfgangmm and others added 5 commits January 15, 2026 09:27

doc(docs): move annotations to separate document; fix docbook errors …

b1f2ae0

…and failing links

Merge 7d815a5 into b1f2ae0

a7c769e

chore: sync shared dependencies from root package.json

fcf8003

fix(sync-deps.js): log versions properly

c73d27b

refactor sync yaml simplify logic

DrRataplan reviewed Jan 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Feat treeshaking: Centralize js dependency management#243

Feat treeshaking: Centralize js dependency management#243
duncdrum wants to merge 15 commits intomainfrom
feat-treeshaking

duncdrum commented Jan 13, 2026

Uh oh!

Uh oh!

DrRataplan Jan 14, 2026

Uh oh!

duncdrum Jan 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DrRataplan Jan 16, 2026

Uh oh!

DrRataplan Jan 16, 2026 •

edited

Loading

Uh oh!

DrRataplan Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

duncdrum commented Jan 13, 2026

Uh oh!

Uh oh!

DrRataplan Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

duncdrum Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DrRataplan Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

DrRataplan Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DrRataplan Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DrRataplan Jan 16, 2026 •

edited

Loading