Depend on JUnit 6 instead of JUnit 5 #3560

trancexpress · 2025-11-19T15:31:41Z

trancexpress · 2025-11-19T15:32:09Z

There is a surprising number of JUnit 5 mentions, including even a quick fix action for adding JUnit 5 to the classpath... Probably for xtend...

This PR so far doesn't touch any of those.

github-actions · 2025-11-19T15:33:56Z

Test Results

6 460 files ±0 6 460 suites ±0 3h 24m 28s ⏱️ + 5m 22s
43 234 tests ±0 42 650 ✅ ±0 584 💤 ±0 0 ❌ ±0
170 250 runs ±0 167 913 ✅ ±0 2 337 💤 ±0 0 ❌ ±0

Results for commit 867059a. ± Comparison against base commit d6256fa.

♻️ This comment has been updated with latest results.

trancexpress · 2025-11-19T17:37:15Z

Running ./full-build.sh --tp=latest locally results in:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:4.0.13:test (default-test) on project org.eclipse.xtext.junit5.tests: No tests found -> [Help 1]

Fully summary:

[INFO] Reactor Summary:
[INFO] 
[INFO] Xtext Parent POM 2.41.0-SNAPSHOT ................... SUCCESS [  0.301 s]
[INFO] org.eclipse.xtext.nodeploy.parent 2.41.0-SNAPSHOT .. SUCCESS [  0.009 s]
[INFO] Xtext Feature Parent 2.41.0-SNAPSHOT ............... SUCCESS [  0.013 s]
[INFO] Eclipse Xtext Developer BOM 2.41.0-SNAPSHOT ........ SUCCESS [  0.041 s]
[INFO] Eclipse Xbase Runtime Library 2.41.0-SNAPSHOT ...... SUCCESS [ 42.603 s]
[INFO] Eclipse Xtend Active Annotations Library 2.41.0-SNAPSHOT SUCCESS [  0.641 s]
[INFO] Eclipse Xtend Runtime Library 2.41.0-SNAPSHOT ...... SUCCESS [  9.411 s]
[INFO] Xtext Utilities 2.41.0-SNAPSHOT .................... SUCCESS [  9.671 s]
[INFO] Xtext Runtime Bundle 2.41.0-SNAPSHOT ............... SUCCESS [ 42.108 s]
[INFO] Common Types Runtime Library 2.41.0-SNAPSHOT ....... SUCCESS [  4.266 s]
[INFO] Xtext Ecore Support 2.41.0-SNAPSHOT ................ SUCCESS [  0.275 s]
[INFO] Xtext Generator 2.41.0-SNAPSHOT .................... SUCCESS [ 12.618 s]
[INFO] Xbase Model 2.41.0-SNAPSHOT ........................ SUCCESS [ 11.470 s]
[INFO] org.eclipse.xtext.web.example.entities 2.41.0-SNAPSHOT SUCCESS [  6.884 s]
[INFO] org.eclipse.xtext.web.example.statemachine 2.41.0-SNAPSHOT SUCCESS [  0.618 s]
[INFO] Xtext IDE Library 2.41.0-SNAPSHOT .................. SUCCESS [  7.316 s]
[INFO] Xtext Testing Library 2.41.0-SNAPSHOT .............. SUCCESS [  9.310 s]
[INFO] Xbase Testing Library 2.41.0-SNAPSHOT .............. SUCCESS [  0.945 s]
[INFO] Xtext Generator Dependencies 2.41.0-SNAPSHOT ....... SUCCESS [  2.886 s]
[INFO] Xtext JSR-45 Smap Installer 2.41.0-SNAPSHOT ........ SUCCESS [  0.358 s]
[INFO] Xtend Core Library 2.41.0-SNAPSHOT ................. SUCCESS [  8.016 s]
[INFO] Bootstrap project for the Xtext language 2.41.0-SNAPSHOT SUCCESS [  0.336 s]
[INFO] Pure Xbase Runtime 2.41.0-SNAPSHOT ................. SUCCESS [  1.189 s]
[INFO] org.eclipse.xtext.ui.codetemplates 2.41.0-SNAPSHOT . SUCCESS [  0.722 s]
[INFO] Xtext Release Engineering Utilities 2.41.0-SNAPSHOT  SUCCESS [  6.734 s]
[INFO] Eclipse Xbase GWT Library 2.41.0-SNAPSHOT .......... SUCCESS [  5.509 s]
[INFO] Eclipse Xtend GWT Library 2.41.0-SNAPSHOT .......... SUCCESS [  0.349 s]
[INFO] Xbase Library Feature 2.41.0-SNAPSHOT .............. SUCCESS [  0.157 s]
[INFO] Tests for Eclipse Xbase Runtime Library 2.41.0-SNAPSHOT SUCCESS [  4.537 s]
[INFO] Xtend Library Feature 2.41.0-SNAPSHOT .............. SUCCESS [  0.128 s]
[INFO] Tests for Eclipse Xtend Runtime Library 2.41.0-SNAPSHOT SUCCESS [  0.650 s]
[INFO] Xtend GWT lib test 2.41.0-SNAPSHOT ................. SUCCESS [ 32.062 s]
[INFO] Xtext Language IDE Support 2.41.0-SNAPSHOT ......... SUCCESS [  0.429 s]
[INFO] Xtext Wizard 2.41.0-SNAPSHOT ....................... SUCCESS [  3.714 s]
[INFO] Common Xtext Testlanguages - Runtime 2.41.0-SNAPSHOT SUCCESS [  2.232 s]
[INFO] Tests for Xtext Testing Library 2.41.0-SNAPSHOT .... SUCCESS [ 19.296 s]
[INFO] Junit 5 Tests for Xtext Testing Library 2.41.0-SNAPSHOT SUCCESS [  1.795 s]
[INFO] Xtext Core Runtime Tests 2.41.0-SNAPSHOT ........... SUCCESS [01:49 min]
[INFO] Common Xtext Testlanguages - IDE Features 2.41.0-SNAPSHOT SUCCESS [  1.776 s]
[INFO] Xtext IDE Tests 2.41.0-SNAPSHOT .................... SUCCESS [ 22.079 s]
[INFO] Xtext Core Runtime JUnit5 Tests 2.41.0-SNAPSHOT .... FAILURE [  7.225 s]
[INFO] Xbase Generic IDE Services 2.41.0-SNAPSHOT ......... SUCCESS [  0.935 s]
[INFO] Xtext Standalone Builder 2.41.0-SNAPSHOT ........... SUCCESS [  0.464 s]
[INFO] Xtext JDT Facade 2.41.0-SNAPSHOT ................... SUCCESS [  0.236 s]
[INFO] Xtext Java Language 2.41.0-SNAPSHOT ................ SUCCESS [  0.350 s]
[INFO] Pure Xbase Generic Ide 2.41.0-SNAPSHOT ............. SUCCESS [  0.582 s]
[INFO] Xbase Test Languages 2.41.0-SNAPSHOT ............... SUCCESS [  1.385 s]
[INFO] Xbase Test Languages Generic IDE Services 2.41.0-SNAPSHOT SUCCESS [  1.207 s]
[INFO] Xbase Test Data 2.41.0-SNAPSHOT .................... SUCCESS [  0.913 s]
[INFO] Pure Xbase Runtime Tests 2.41.0-SNAPSHOT ........... SUCCESS [ 22.276 s]
[INFO] Xtext Eclipse tests plugins parent 2.41.0-SNAPSHOT . SUCCESS [  0.003 s]
[INFO] org.eclipse.xtext.common.types.edit 2.41.0-SNAPSHOT  SUCCESS [  2.152 s]
[INFO] org.eclipse.xtext.ui 2.41.0-SNAPSHOT ............... SUCCESS [ 18.266 s]
[INFO] org.eclipse.xtext.common.types.ui 2.41.0-SNAPSHOT .. SUCCESS [  0.880 s]
[INFO] org.eclipse.xtext.builder 2.41.0-SNAPSHOT .......... SUCCESS [  2.607 s]
[INFO] org.eclipse.xtext.ui.shared 2.41.0-SNAPSHOT ........ SUCCESS [  0.595 s]
[INFO] org.eclipse.xtext.ui.codetemplates.ide 2.41.0-SNAPSHOT SUCCESS [  0.377 s]
[INFO] org.eclipse.xtext.ui.codetemplates.ui 2.41.0-SNAPSHOT SUCCESS [  0.713 s]
[INFO] org.eclipse.xtext.common.types.shared 2.41.0-SNAPSHOT SUCCESS [  0.459 s]
[INFO] org.eclipse.xtext.xbase.ui 2.41.0-SNAPSHOT ......... SUCCESS [ 20.791 s]
[INFO] org.eclipse.xtext.ui.testing 2.41.0-SNAPSHOT ....... SUCCESS [  0.665 s]
[INFO] org.eclipse.xtext.xbase.ui.testing 2.41.0-SNAPSHOT . SUCCESS [  0.453 s]
[INFO] org.eclipse.xtext.logging 2.41.0-SNAPSHOT .......... SUCCESS [  0.139 s]
[INFO] org.eclipse.xtext.purexbase.ui 2.41.0-SNAPSHOT ..... SUCCESS [  0.571 s]
[INFO] org.eclipse.xtext.purexbase.eclipse.tests 2.41.0-SNAPSHOT SUCCESS [01:08 min]
[INFO] Xtext Xbase Tests 2.41.0-SNAPSHOT .................. SUCCESS [03:57 min]
[INFO] Xtext Java Language Tests 2.41.0-SNAPSHOT .......... SUCCESS [ 12.728 s]
[INFO] Xtext Extras Tests 2.41.0-SNAPSHOT ................. SUCCESS [  4.725 s]
[INFO] Xtext Standalone Builder Tests 2.41.0-SNAPSHOT ..... SUCCESS [  8.602 s]
[INFO] Common Types Runtime Library Tests 2.41.0-SNAPSHOT . SUCCESS [02:23 min]
[INFO] org.eclipse.xtext.activities 2.41.0-SNAPSHOT ....... SUCCESS [  0.146 s]
[INFO] org.eclipse.xtext.buildship 2.41.0-SNAPSHOT ........ SUCCESS [  2.506 s]
[INFO] org.eclipse.xtext.ui.codemining 2.41.0-SNAPSHOT .... SUCCESS [  0.323 s]
[INFO] org.eclipse.xtext.common.types.eclipse.tests 2.41.0-SNAPSHOT SUCCESS [02:21 min]
[INFO] org.eclipse.xtext.common.types.shared.jdt38 2.41.0-SNAPSHOT SUCCESS [  0.511 s]
[INFO] org.eclipse.xtext.m2e 2.41.0-SNAPSHOT .............. SUCCESS [  2.751 s]
[INFO] org.eclipse.xtext.ui.ecore 2.41.0-SNAPSHOT ......... SUCCESS [  0.387 s]
[INFO] org.eclipse.xtext.xtext.ui 2.41.0-SNAPSHOT ......... SUCCESS [  0.948 s]
[INFO] org.eclipse.xtext.xtext.ui.graph 2.41.0-SNAPSHOT ... SUCCESS [  1.970 s]
[INFO] org.eclipse.xtext.doc 2.41.0-SNAPSHOT .............. SUCCESS [  0.311 s]
[INFO] org.eclipse.xtext.xtext.ui.examples 2.41.0-SNAPSHOT  SUCCESS [  0.565 s]
[INFO] org.eclipse.xtext.testlanguages.ui 2.41.0-SNAPSHOT . SUCCESS [  0.744 s]
[INFO] org.eclipse.xtext.builder.tests 2.41.0-SNAPSHOT .... SUCCESS [ 59.605 s]
[INFO] org.eclipse.xtext.ui.codetemplates.tests 2.41.0-SNAPSHOT SUCCESS [  7.998 s]
[INFO] org.eclipse.xtext.eclipse.tests 2.41.0-SNAPSHOT .... SUCCESS [  6.760 s]
[INFO] org.eclipse.xtext.ui.tests 2.41.0-SNAPSHOT ......... SUCCESS [02:27 min]
[INFO] org.eclipse.xtext.xbase.testlanguages.ui 2.41.0-SNAPSHOT SUCCESS [  0.688 s]
[INFO] org.eclipse.xtext.xbase.ui.tests 2.41.0-SNAPSHOT ... SUCCESS [07:56 min]
[INFO] org.eclipse.xtext.xtext.ui.graph.tests 2.41.0-SNAPSHOT SUCCESS [  8.155 s]
[INFO] org.eclipse.xtext.xtext.ui.tests 2.41.0-SNAPSHOT ... SUCCESS [ 43.200 s]
[INFO] org.eclipse.xtext.web.example.statemachine.ide 2.41.0-SNAPSHOT SUCCESS [  0.604 s]
[INFO] Xtext Web API 2.41.0-SNAPSHOT ...................... SUCCESS [ 18.398 s]
[INFO] org.eclipse.xtext.web.example.entities.ide 2.41.0-SNAPSHOT SUCCESS [  0.928 s]
[INFO] Xbase Web Integration 2.41.0-SNAPSHOT .............. SUCCESS [  6.749 s]
[INFO] Xtext Servlet 2.41.0-SNAPSHOT ...................... SUCCESS [  1.648 s]
[INFO] org.eclipse.xtext.web.example.jetty 2.41.0-SNAPSHOT  SUCCESS [ 19.227 s]
[INFO] Xtext Maven Plugin Parent POM 2.41.0-SNAPSHOT ...... SUCCESS [  2.256 s]
[INFO] Xtext Maven Plugin 2.41.0-SNAPSHOT ................. SUCCESS [04:40 min]
[INFO] Xtend Maven Plugin Parent POM 2.41.0-SNAPSHOT ...... SUCCESS [  0.008 s]
[INFO] Xtend IDE Common 2.41.0-SNAPSHOT ................... SUCCESS [  3.952 s]
[INFO] Xtend Maven Plugin 2.41.0-SNAPSHOT ................. SUCCESS [02:51 min]
[INFO] Xtend Archetype 2.41.0-SNAPSHOT .................... SUCCESS [ 17.407 s]
[INFO] org.eclipse.xtend.tycho.tests.parent 2.41.0-SNAPSHOT SUCCESS [  0.004 s]
[INFO] Xtend IDE 2.41.0-SNAPSHOT .......................... SUCCESS [  5.646 s]
[INFO] org.eclipse.xtend.ide.tests.data 2.41.0-SNAPSHOT ... SUCCESS [  0.252 s]
[INFO] Xtend Documentation 2.41.0-SNAPSHOT ................ SUCCESS [  0.133 s]
[INFO] Xtend Examples 2.41.0-SNAPSHOT ..................... SUCCESS [  0.349 s]
[INFO] org.eclipse.xtend.m2e 2.41.0-SNAPSHOT .............. SUCCESS [  0.535 s]
[INFO] org.eclipse.xtend.standalone 2.41.0-SNAPSHOT ....... SUCCESS [  0.147 s]
[INFO] Xtend Core Library Tests 2.41.0-SNAPSHOT ........... SUCCESS [02:30 min]
[INFO] org.eclipse.xtend.ide.tests 2.41.0-SNAPSHOT ........ SUCCESS [10:37 min]
[INFO] Xtend Performance Tests 2.41.0-SNAPSHOT ............ SUCCESS [01:40 min]
[INFO] org.eclipse.xtend.swtbot 2.41.0-SNAPSHOT ........... SUCCESS [  3.285 s]
[INFO] org.eclipse.xtend.ide.swtbot.tests 2.41.0-SNAPSHOT . SUCCESS [ 14.889 s]
[INFO] org.eclipse.xtext.docs 2.41.0-SNAPSHOT ............. SUCCESS [  0.086 s]
[INFO] org.eclipse.xtext.runtime 2.41.0-SNAPSHOT .......... SUCCESS [  0.180 s]
[INFO] org.eclipse.xtext.ui 2.41.0-SNAPSHOT ............... SUCCESS [  0.268 s]
[INFO] org.eclipse.xtext.examples 2.41.0-SNAPSHOT ......... SUCCESS [  0.204 s]
[INFO] Xbase Feature 2.41.0-SNAPSHOT ...................... SUCCESS [  0.213 s]
[INFO] org.eclipse.xtext.redist 2.41.0-SNAPSHOT ........... SUCCESS [  0.263 s]
[INFO] org.eclipse.xtext.xtext.ui.graph 2.41.0-SNAPSHOT ... SUCCESS [  0.155 s]
[INFO] org.eclipse.xtext.xtext.ui 2.41.0-SNAPSHOT ......... SUCCESS [  0.285 s]
[INFO] org.eclipse.emf.mwe2.language.sdk 2.24.0.v20250823-0643 SUCCESS [  0.059 s]
[INFO] org.eclipse.xtend.sdk 2.41.0-SNAPSHOT .............. SUCCESS [  0.273 s]
[INFO] org.eclipse.xtext.sdk 2.41.0-SNAPSHOT .............. SUCCESS [  0.406 s]
[INFO] org.eclipse.xtext.p2repository 2.41.0-SNAPSHOT ..... SUCCESS [  3.647 s]
[INFO] org.eclipse.xtext.full.releng 1.0.0-SNAPSHOT ....... SUCCESS [  0.027 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  54:54 min
[INFO] Finished at: 2025-11-19T18:49:37+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:4.0.13:test (default-test) on project org.eclipse.xtext.junit5.tests: No tests found -> [Help 1]

At least in JDT/PDE, this was usually an indicator of mixing JUnit 5 and 6 at runtime. It might be something else here. Such as JUnit 4 tests...

Trying this:

➜  org.eclipse.xtext.junit5.tests git:(gh3552) ✗ git diff
diff --git a/org.eclipse.xtext.junit5.tests/pom.xml b/org.eclipse.xtext.junit5.tests/pom.xml
index e469288647..067afd86f5 100644
--- a/org.eclipse.xtext.junit5.tests/pom.xml
+++ b/org.eclipse.xtext.junit5.tests/pom.xml
@@ -26,7 +26,7 @@
                                <groupId>org.eclipse.tycho</groupId>
                                <artifactId>tycho-surefire-plugin</artifactId>
                                <configuration>
-                                       <providerHint>junit5</providerHint>
+                                       <providerHint>junit6</providerHint>
                                </configuration>
                        </plugin>
                </plugins>

Results in:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:4.0.13:test (default-test) on project org.eclipse.xtext.junit5.tests: Could not find test framework provider with role hint 'junit6'. Available providers: [junit59withvintage, junit4, junit5, junit56, junit55, junit54, junit59, junit58, junit512withvintage, junit57, junit47, testng, junit512, junit3, junit57withvintage, junit58withvintage] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

cdietrich · 2025-11-19T17:39:12Z

maybe this is a way too old tycho?

org.eclipse.xtext.dev-bom/pom.xml

See: eclipse-xtext#3552

trancexpress · 2025-11-19T20:27:37Z

maybe this is a way too old tycho?

Should I try updating to tycho 5.0 (in a separate PR)?

cdietrich · 2025-11-20T03:20:54Z

see #3509
see also https://github.com/eclipse-xtext/xtext/tree/cd_tycho50
but its complicated, cause java 21. implications on wizard etc unclear
see also #3546

we had a brief discussion to look into that someone after the current release
but as said i currently have zero capacity

(building milestones and releases is actually already beyond my cappa)

cdietrich · 2025-11-20T07:59:09Z

the problem with tycho 5 is
we need a solution how to deal with it in

wizard
domain model example

what happens if use selects java 17 in wizard? should we have a fallback to old version.

this also affecs junit 5/6 what should we offer the user.

cdietrich · 2025-11-20T07:59:29Z

can you also check Jenkinsfile

trancexpress · 2025-11-20T08:50:56Z

With maven 3.9.9 and tycho 5.0.0, there is only one error:

[INFO] Xtend Archetype 2.41.0-SNAPSHOT .................... FAILURE [  1.901 s]

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.5.0:install (install dependencies in local test repo) on project xtend-archetype: The following artifacts could not be resolved: p2.eclipse.plugin:de.itemis.xtext.antlr:pom:2.1.1.v201405091103 (absent): Could not find artifact p2.eclipse.plugin:de.itemis.xtext.antlr:pom:2.1.1.v201405091103 in lsp4j-from-jenkins (https://ci.eclipse.org/xtext/job/lsp4j/lastStableBuild/artifact/build/maven-repository) -> [Help 1]

trancexpress · 2025-11-20T08:54:37Z

the problem with tycho 5 is we need a solution how to deal with it in

what happens if use selects java 17 in wizard? should we have a fallback to old version.

this also affecs junit 5/6 what should we offer the user.

We can always delay the JUnit 6 update for when xtext supports only Java 21+. That will make things simple.

Advantest is not in a rush, since the workaround is trivial.

trancexpress force-pushed the gh3552 branch 2 times, most recently from 2c93f7a to ad11eb8 Compare November 19, 2025 16:50

cdietrich reviewed Nov 19, 2025

View reviewed changes

org.eclipse.xtext.dev-bom/pom.xml Show resolved Hide resolved

Depend on JUnit 6 instead of JUnit 5

b7339aa

See: eclipse-xtext#3552

trancexpress force-pushed the gh3552 branch from ad11eb8 to b7339aa Compare November 19, 2025 19:43

trancexpress added 2 commits November 20, 2025 09:02

Update to tycho 5

9cef1fc

Update to maven 3.9.9

867059a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Depend on JUnit 6 instead of JUnit 5 #3560

Depend on JUnit 6 instead of JUnit 5 #3560

trancexpress commented Nov 19, 2025

Uh oh!

trancexpress commented Nov 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

trancexpress commented Nov 19, 2025 •

edited

Loading

Uh oh!

cdietrich commented Nov 19, 2025

Uh oh!

Uh oh!

trancexpress commented Nov 19, 2025 •

edited

Loading

Uh oh!

cdietrich commented Nov 20, 2025 •

edited

Loading

Uh oh!

cdietrich commented Nov 20, 2025

Uh oh!

cdietrich commented Nov 20, 2025

Uh oh!

trancexpress commented Nov 20, 2025

Uh oh!

trancexpress commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Depend on JUnit 6 instead of JUnit 5 #3560

Are you sure you want to change the base?

Depend on JUnit 6 instead of JUnit 5 #3560

Conversation

trancexpress commented Nov 19, 2025

Uh oh!

trancexpress commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

trancexpress commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdietrich commented Nov 19, 2025

Uh oh!

Uh oh!

trancexpress commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdietrich commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdietrich commented Nov 20, 2025

Uh oh!

cdietrich commented Nov 20, 2025

Uh oh!

trancexpress commented Nov 20, 2025

Uh oh!

trancexpress commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

trancexpress commented Nov 19, 2025 •

edited

Loading

github-actions bot commented Nov 19, 2025 •

edited

Loading

trancexpress commented Nov 19, 2025 •

edited

Loading

trancexpress commented Nov 19, 2025 •

edited

Loading

cdietrich commented Nov 20, 2025 •

edited

Loading