Skip to content

Disable Toggle Instruction Step Mode command using activity support. #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruspl-afed merged 1 commit into from
Jul 4, 2025
Merged

Disable Toggle Instruction Step Mode command using activity support. #1221

ruspl-afed merged 1 commit into from
Jul 4, 2025
+39 −0

Conversation

@raghucssit
Copy link
Contributor

@raghucssit raghucssit commented Jun 26, 2025

TISM command is always visible if the CDT Debug UI plug-in is not loaded yet. This happened due to platform limitation.So handle visibility using activity support.

see #1220

@raghucssit raghucssit force-pushed the tism_command_activity_support branch from d36dad4 to 98f6b48 Compare June 26, 2025 15:14
@raghucssit raghucssit requested a review from iloveeclipse June 26, 2025 15:15
@raghucssit raghucssit force-pushed the tism_command_activity_support branch from 98f6b48 to 2449a61 Compare June 26, 2025 18:22
ruspl-afed
ruspl-afed requested changes Jun 27, 2025
View reviewed changes
Copy link
Member

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide i18n for introduced labels and descriptions

@raghucssit raghucssit force-pushed the tism_command_activity_support branch from 2449a61 to 9edeccc Compare July 2, 2025 13:50
@raghucssit raghucssit force-pushed the tism_command_activity_support branch 2 times, most recently from 158ac3d to 15457d8 Compare July 2, 2025 14:02
@raghucssit
Copy link
Contributor Author

raghucssit commented Jul 2, 2025

Please provide i18n for introduced labels and descriptions

Fixed.

@raghucssit raghucssit mentioned this pull request Jul 2, 2025
Draft
@raghucssit
Copy link
Contributor Author

raghucssit commented Jul 2, 2025

We can already define an id for a contribution item. And that can be used for activity support.
I have updated PR to remove all the code needed to activate or deactivate in the Bundle Activator.

@raghucssit
Copy link
Contributor Author

raghucssit commented Jul 2, 2025

This PR by default disables Toggle Instruction Step Mode command from main:run menu and main:toolbar.

iloveeclipse
iloveeclipse suggested changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please after changes attach a screenshot of the Capabilities page where the new activity category & sub items are shown.

@raghucssit
Copy link
Contributor Author

raghucssit commented Jul 2, 2025

General->Capabilities preference page after this fix.
This activity is default disabled.
image

@raghucssit raghucssit force-pushed the tism_command_activity_support branch from 15457d8 to 6f2b8bc Compare July 2, 2025 16:08
@raghucssit raghucssit requested a review from iloveeclipse July 2, 2025 16:08
iloveeclipse
iloveeclipse approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I haven't tested with updated CDT, but I assume you did it.

ruspl-afed
ruspl-afed reviewed Jul 3, 2025
View reviewed changes
@raghucssit raghucssit requested a review from ruspl-afed July 4, 2025 08:35
@raghucssit
Disable Toggle Instruction Step Mode command using activity support.
2127130 
TISM command is always visible if the CDT Debug UI plug-in is not loaded
yet. This happened due to platform limitation.So handle visibility using
activity support.

see eclipse-cdt#1220
@raghucssit raghucssit force-pushed the tism_command_activity_support branch from 6f2b8bc to 2127130 Compare July 4, 2025 11:53
ruspl-afed
ruspl-afed approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruspl-afed ruspl-afed merged commit 5783b82 into eclipse-cdt:main Jul 4, 2025
4 checks passed
@jonahgraham jonahgraham added this to the 12.3.0 milestone Sep 12, 2025
@jonahgraham jonahgraham modified the milestones: 12.3.0, 12.2.0 Sep 12, 2025
@jonahgraham
Copy link
Member

jonahgraham commented Oct 14, 2025

This should have had a N&N entry created because it changes the UI for end users in a way that is affecting ISVs. At the recent CDT call it was identified that numerous ISVs documentation point users to the Run menu and main toolbar (next to other debug buttons) on where to find instruction stepping mode.

An example is the stm32cubeide user manual available from https://www.st.com/en/development-tools/stm32cubeide.html#documentation - pages 169/170

jonahgraham added a commit to jonahgraham/cdt that referenced this pull request Oct 14, 2025
@jonahgraham
Add N&N entry for Instruction Stepping Mode Button visibility
f9994d7 
This is a follow-up to eclipse-cdt#1221
@jonahgraham jonahgraham mentioned this pull request Oct 14, 2025
Merged
@jonahgraham
Copy link
Member

jonahgraham commented Oct 14, 2025

This should have had a N&N entry

PR proposed here #1357

jonahgraham added a commit that referenced this pull request Oct 18, 2025
@jonahgraham
Add N&N entry for Instruction Stepping Mode Button visibility (#1357)
a32a8c6 
This is a follow-up to #1221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruspl-afed ruspl-afed ruspl-afed approved these changes

+1 more reviewer

@iloveeclipse iloveeclipse iloveeclipse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

12.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@raghucssit @jonahgraham @iloveeclipse @ruspl-afed