Ext version 3.0 #42
Open
Ext version 3.0 #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 2, 2025 13:10
Collaborator
|
Thank you for your work. Is the change complete already?
|
Author
|
Dear Uwe
>>see in [ https://github.com/ebics-java/ebics-java-client/pull/42/files#diff-36403ba901a26680d3ae7710e247578771027ad720caba9a20eed49f906bc20d | DownloadInitializationRequestElement.java ] the EbicsParams is added but it seems not used anywhere.
the class is used in FileTransfert line 211
regarding the send/fetchFile<version> it was for separate them but it can be change as you like.
De: "Uwe Maurer" ***@***.***>
À: "ebics-java/ebics-java-client" ***@***.***>
Cc: "osc-lab" ***@***.***>, "Author" ***@***.***>
Envoyé: Mercredi 3 Décembre 2025 09:09:50
Objet: Re: [ebics-java/ebics-java-client] Ext version 3.0 (PR #42)
uwemaurer left a comment [ #42 (comment) | (ebics-java/ebics-java-client#42) ]
Thank you for your work. Is the change complete already?
* I see in [ https://github.com/ebics-java/ebics-java-client/pull/42/files#diff-36403ba901a26680d3ae7710e247578771027ad720caba9a20eed49f906bc20d | DownloadInitializationRequestElement.java ] the EbicsParams is added but it seems not used anywhere.
* Why was the record converted to a class? Are you trying to run it on older Java versions?
* I think we don't need the V2 and V3 functions (this library is for V3 only) so just add a method with the new EbicsParam as parameter (no need to mark them as V2 or V3)
—
Reply to this email directly, [ #42 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AN2AB2RCM3NGG3DP7Z3JKGT372LE5AVCNFSM6AAAAACNZ7MLKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBVGU3TQMBTHE | unsubscribe ] .
You are receiving this because you authored the thread. Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your information I remove your file EbicsUploadParams and replace it by EbicsParams that I use for Upload and Fetch documents.