-
Notifications
You must be signed in to change notification settings - Fork 55
Feat: Sandbox Logs #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ben-fornefeld
wants to merge
23
commits into
main
Choose a base branch
from
implement-sandbox-details-logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat: Sandbox Logs #239
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
aad0111
update infra oapi spec
ben-fornefeld 3489b2b
wip: first version of logs viewer
ben-fornefeld 11e744d
Merge branch 'main' into implement-sandbox-details-logs
ben-fornefeld 4b2a586
improve: sandboxes details title
ben-fornefeld 656aab1
fix: initial logs ordering
ben-fornefeld edc5f95
refactor: streamline header components and improve logs handling
ben-fornefeld 9560582
add: storage icon
ben-fornefeld 600e519
improve: timestamps
ben-fornefeld dbebfec
improve: log level column
ben-fornefeld bb06a7d
add: dashboard layout copyable header title value
ben-fornefeld 6ad9e7e
refactor: header layout
ben-fornefeld 3ea7053
improve: logs readability
ben-fornefeld d53c53e
improve: loading / error state handling + config + state management
ben-fornefeld 97057b5
fix: address cursor comments
ben-fornefeld c1aee93
fix: log state management
ben-fornefeld 967f78a
cleanup: sandbox logs
ben-fornefeld 1ab6870
chore: sync sandbox and build logs styling
ben-fornefeld 5a71da5
Merge branch 'main' into implement-sandbox-details-logs
ben-fornefeld aecda0f
fix: refactor init cursor logic for forward fetching logs
ben-fornefeld 719f8cb
improve: sandbox stopped log forward fetch draining
ben-fornefeld c02c4a3
refactor: build logs to match sandbox logs behavior
ben-fornefeld 0442b21
chore: improve dashboard tabs memo
ben-fornefeld 4ad367b
refactor: use reverse in backwards logs router and cut unecessary sor…
ben-fornefeld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
src/app/dashboard/[teamIdOrSlug]/sandboxes/[sandboxId]/logs/loading.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { default } from '@/features/dashboard/loading-layout' |
11 changes: 11 additions & 0 deletions
11
src/app/dashboard/[teamIdOrSlug]/sandboxes/[sandboxId]/logs/page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import SandboxLogsView from '@/features/dashboard/sandbox/logs/view' | ||
|
|
||
| export default async function SandboxLogsPage({ | ||
| params, | ||
| }: { | ||
| params: Promise<{ teamIdOrSlug: string; sandboxId: string }> | ||
| }) { | ||
| const { teamIdOrSlug, sandboxId } = await params | ||
|
|
||
| return <SandboxLogsView teamIdOrSlug={teamIdOrSlug} sandboxId={sandboxId} /> | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const LOG_RETENTION_MS = 7 * 24 * 60 * 60 * 1000 // 7 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused duplicate URL definition is dead code
Low Severity
PROTECTED_URLS.SANDBOXproduces the exact same URL asPROTECTED_URLS.SANDBOX_LOGS(both resolve to.../sandboxes/${sandboxId}/logs), andSANDBOXis never referenced anywhere in the codebase. It's unused dead code introduced by this diff.