Skip to content

Conversation

@jprestop
Copy link
Collaborator

@jprestop jprestop commented Dec 9, 2025

Pull Request Testing

Changes include any necessary updates to:

  • noaa_install.rst instructions

  • existing builds.rst, including the addition of the machine Ursa

  • updates to modulefiles used on HPCs

  • removal of derecho modulefile since no installation was done there

  • Describe testing already performed for these changes:

Reviewed the changes in RTD here.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Ensure all tests pass and review change for any typos or obvious errors.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [20251212].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METplus-6.2.1 Bugfix milestone Dec 9, 2025
@jprestop jprestop requested a review from georgemccabe December 9, 2025 22:37
@jprestop jprestop moved this from 🩺 Needs Triage to 🔎 In review in Coordinated METplus-6.2 Support Dec 9, 2025
@jprestop jprestop linked an issue Dec 9, 2025 that may be closed by this pull request
24 tasks
Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jprestop jprestop merged commit 7a7dfd1 into main_v6.2 Dec 10, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in Coordinated METplus-6.2 Support Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Update the Existing Builds documentation with 6.2 installation information

3 participants