Skip to content

Conversation

@georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Oct 24, 2025

Pull Request Testing

  • Describe testing already performed for these changes:

Ran CTP/HI use case locally before and after making changes to refactor the python embedding scripts. Confirmed that no differences in the output were present after the modifications.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  • Review code changes (as desired)
  • Review output from land use cases to confirm that contain the same results as before
  • Confirm that title of Land use case category should not be changed or suggest change.
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

Rename of use case category will result in new set of truth data to be generated

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 11/11/2025.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplus-7.0.0 milestone Oct 24, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-7.0 Development Oct 24, 2025
@georgemccabe georgemccabe moved this from 🩺 Needs Triage to 🔎 In review in METplus-7.0 Development Oct 24, 2025
@georgemccabe georgemccabe linked an issue Oct 24, 2025 that may be closed by this pull request
24 tasks
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-7.0 Development Oct 24, 2025
…line argument to control which derivation to run
…and line argument to control which derivation to run
@georgemccabe georgemccabe reopened this Oct 24, 2025
@georgemccabe georgemccabe moved this from 🏁 Done to 🔎 In review in METplus-7.0 Development Oct 24, 2025
@georgemccabe georgemccabe marked this pull request as ready for review November 12, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In review

Development

Successfully merging this pull request may close these issues.

Change the model_applications use case category land_surface to be land

3 participants