Skip to content

Conversation

@bikegeek
Copy link
Collaborator

@bikegeek bikegeek commented Dec 4, 2025

Pull Request Testing

  • Describe testing already performed for these changes:

on 'dakota':
Using METviewer, generate a plot via Python and request Y1 points. Y1 points should appear/be saved in the same location where the other METviewer data points are saved

Data, plots, xml, and scripts are saved here on 'dakota':
/opt/tomcat9/vxwww/webapps/metviewer_output/data

Using the following XML config file:
plot_Python-test_METplotpy.xml.txt

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

same as above, check that Y1 points are created in the data directory where METviewer saves .data, .yaml files

Data, plots, xml, and scripts are saved here on 'dakota':
/opt/tomcat9/vxwww/webapps/metviewer_output/data

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [ No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [?]

    If yes, please describe:

  • [] Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek requested a review from CPKalb December 4, 2025 01:36
@bikegeek bikegeek added the component: code cleanup Code cleanup and maintenance issue label Dec 4, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-7.0 Development Dec 4, 2025
@bikegeek bikegeek moved this from 🩺 Needs Triage to 🟢 Ready in METplus-7.0 Development Dec 4, 2025
@bikegeek bikegeek added this to the METplotpy-4.0.0 milestone Dec 4, 2025
omit the pyx files
@CPKalb
Copy link
Contributor

CPKalb commented Dec 4, 2025

I can't access the /opt/tomcat9/vxwww/webapps/metviewer_output/data directory on dakota. I get a permission denied error.

The R plot, however, is working for me, and I do see data under the "Y1 Points" tab. I don't get any output under the "Y2 Points' tab.

@bikegeek
Copy link
Collaborator Author

bikegeek commented Dec 5, 2025

@CPKalb log in as user vxwww, because vxwww owns the directory and files.

The plot example only has Y1 axis, if you add info for a Y2 axis, then you should see the Y2 points. Try using this XML config file:
plot_Python_Y1_and_Y2.xml.txt

and look for the newer Y1 and Y2 points ( plot_Python_Y1_and_Y2.points1, plot_Python_Y1_and_Y2.points2) under
/opt/tomcat9/vxwww/webapps/metviewer_output/data

Copy link
Contributor

@CPKalb CPKalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the points are in the expected location and the plot is working.

@bikegeek bikegeek merged commit 9ee17d3 into develop Dec 8, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from 🟢 Ready to 🏁 Done in METplus-7.0 Development Dec 8, 2025
@bikegeek bikegeek self-assigned this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: code cleanup Code cleanup and maintenance issue

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

Bugfix Use the METviewer data output directory when the points path is not defined in the yaml config file created by METviewer

3 participants