Skip to content

Conversation

@bikegeek
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek added this to the METplotpy-3.2.0 milestone Nov 13, 2025
@bikegeek bikegeek requested a review from jprestop November 13, 2025 19:27
@bikegeek bikegeek added the type: task An actionable item of work label Nov 13, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.2 Development Nov 13, 2025
@jprestop jprestop moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.2 Development Nov 13, 2025
@jprestop jprestop linked an issue Nov 13, 2025 that may be closed by this pull request
23 tasks
Add source and omit settings for coverage tool
@jprestop jprestop marked this pull request as draft November 13, 2025 20:23
@jprestop
Copy link
Contributor

@bikegeek The SonarQube scans are failing, seemingly due to:

No source for code: 'test/histogram_2d/src/netCDF4/_netCDF4.pyx'; see https://coverage.readthedocs.io/en/7.11.3/messages.html#error-no-source
Error: Process completed with exit code 1.

Based on the information in the link, I've tried to modify the pyproject.toml file to get rid of the error. Take a look at my modifications when you get a chance. I still have not found a solution. Are you familiar with the pyproject.toml file? If so, any ideas on how to resolve the error? I'm going to move on to the other releases with the hope that you'll know better how to resolve this problem.

bikegeek and others added 5 commits November 13, 2025 16:32
move the omit from the tool.coverage.report to the tool.coverage.run to see if the histogram_2d/src/netCDF4 can be omitted from the trace
try [run] source=. to prevent measuring code outside of project
@bikegeek bikegeek marked this pull request as ready for review November 14, 2025 13:19
Copy link
Contributor

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bikegeek Thank you so much for figuring out the problem! I approve this request.

@bikegeek bikegeek merged commit f7e7e85 into main_v3.2 Nov 14, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.2 Development Nov 14, 2025
@jprestop jprestop deleted the feature_550_v3.2.0 branch December 1, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An actionable item of work

Projects

No open projects
Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

Create the METplotpy v6.2.0 release

3 participants