-
Notifications
You must be signed in to change notification settings - Fork 7
Feature 550 v3.2.0 #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 550 v3.2.0 #551
Conversation
Add source and omit settings for coverage tool
Updated source paths for coverage tool and adjusted omit settings.
Updated coverage configuration to omit specific files.
|
@bikegeek The SonarQube scans are failing, seemingly due to:
Based on the information in the link, I've tried to modify the pyproject.toml file to get rid of the error. Take a look at my modifications when you get a chance. I still have not found a solution. Are you familiar with the pyproject.toml file? If so, any ideas on how to resolve the error? I'm going to move on to the other releases with the hope that you'll know better how to resolve this problem. |
move the omit from the tool.coverage.report to the tool.coverage.run to see if the histogram_2d/src/netCDF4 can be omitted from the trace
try [run] source=. to prevent measuring code outside of project
jprestop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bikegeek Thank you so much for figuring out the problem! I approve this request.
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases