-
Notifications
You must be signed in to change notification settings - Fork 0
Support orcid accounts #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: splinke-to-sub-projects
Are you sure you want to change the base?
Conversation
Resolves: #13
|
🚅 Environment sprinkler-pr-14 in Drips App has no services deployed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for ORCID accounts by implementing a new processing pipeline alongside the existing drip lists and projects processing. The changes introduce ORCID account validation, contract interaction capabilities, and database schema updates to support the new functionality.
- Adds ORCID account processing with validation logic to ensure accounts split 100% to their owners
- Introduces repo sub-account driver contract integration for calculating sub-project account IDs
- Updates database queries to use new snake_case table naming convention
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.ts | Adds repoSubAccountDriver contract address to Network type |
| src/queries/getTokens.ts | Updates table names from PascalCase to snake_case |
| src/queries/getCurrentSplitsReceivers.ts | Simplifies splits receiver query logic and updates schema |
| src/queries/getAllProjectsSortedByCreationDate.ts | Adds sub-project calculation and renames function |
| src/queries/getAllOrcidAccountsWithSplits.ts | New query for retrieving ORCID accounts with splits data |
| src/queries/getAllDripListsSortedByCreationDate.ts | Updates table name to snake_case |
| src/index.ts | Integrates ORCID processing into main workflow |
| src/getNetwork.ts | Adds repoSubAccountDriver contract addresses |
| src/contracts/unwrapEthersResult.ts | Utility for unwrapping ethers contract results |
| src/contracts/repoSubAccountDriverAbi.ts | ABI definition for repo sub-account driver contract |
| src/contracts/repoSubAccountDriver.ts | Contract interaction wrapper |
| src/contracts/drips-client.ts | Refactors to use shared unwrap utility |
No description provided.