fix schedule applying even when toggled off #1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚅 Deployed to the app-pr-1805 environment in Drips App
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where stream scheduling was being applied even when the "Specify start and end dates" toggle was turned off. The fix introduces a shouldSchedule flag that properly gates the scheduling parameters.
Key Changes
- Added conditional logic to only pass
startAtanddurationSecondsto the stream creation function when scheduling is explicitly enabled - Replaced escaped quotes with HTML entities in an error message string
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.