Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 5, 2025

The retry loop workaround for microsoft/vscode#256031 is no longer needed as the issue has been fixed in vscode-insiders.

Changes

  • test/vscodeLauncher.ts: Remove the 5-attempt retry loop with 2s delays in installExtensions()
  • azure-pipelines.yml: Always use insiders instead of conditionally selecting stable/insiders based on build reason
  • azure-pipelines/profiling.yml: Switch testVSCodeVersion from stable to insiders

Before

for (let attempts = 0; attempts < 5; attempts++) {
    try {
        await installExtension(extensionId, vscodeCli, vscodeArgs);
        installSucceeded = true;
        break;
    } catch (error) {
        console.warn(`Failed to install extension ${extensionId}; retrying: ${error}`);
        installError = error;
        await new Promise((resolve) => setTimeout(resolve, 2000));
    }
}

After

for (const extensionId of extensionIds) {
    await installExtension(extensionId, vscodeCli, vscodeArgs);
}
Original prompt

Remove the workaround here to call install extension in a loop - https://github.com/dotnet/vscode-csharp/blob/main/test/vscodeLauncher.ts#L72

The issue has been fixed in vscode-insiders. Update the azure-pipelines yaml and profiling yaml to use the insiders version


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…e insiders

- Remove the retry loop workaround for microsoft/vscode#256031
  in test/vscodeLauncher.ts since the issue has been fixed in vscode-insiders
- Update azure-pipelines.yml to always use insiders version instead of
  conditionally using stable/insiders
- Update azure-pipelines/profiling.yml to use insiders version

Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove workaround for install extension in loop Remove VSCode extension install retry workaround, use insiders for all tests Dec 5, 2025
Copilot AI requested a review from dibarbet December 5, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants