-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[manual] Merge release/9.0-staging into release/9.0 #122242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jozkee
wants to merge
40
commits into
dotnet:release/9.0
Choose a base branch
from
jozkee:release/9.0-staging
base: release/9.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+594
−860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Backport all changes from dotnet#108582. * Fix unexpected token.
…ease/9.0-staging [automated] Merge branch 'release/9.0' => 'release/9.0-staging'
….1 (dotnet#120643) On relative base path root Microsoft.NETCore.Runtime.ICU.Transport From Version 9.0.0-rtm.25509.1 -> To Version 9.0.0-rtm.25511.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…12.2 (dotnet#120686) On relative base path root Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil From Version 0.11.5-alpha.25504.2 -> To Version 0.11.5-alpha.25512.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ference-packages (dotnet#120762) This pull request updates the following dependencies [marker]: <> (Begin:3b2e34b4-9c9e-4da6-a358-02c0b764a22e) ## From https://github.com/dotnet/source-build-reference-packages - **Subscription**: [3b2e34b4-9c9e-4da6-a358-02c0b764a22e](https://maestro.dot.net/subscriptions?search=3b2e34b4-9c9e-4da6-a358-02c0b764a22e) - **Build**: [20251006.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2809489) ([285882](https://maestro.dot.net/channel/5175/github:dotnet:source-build-reference-packages/build/285882)) - **Date Produced**: October 6, 2025 4:01:36 PM UTC - **Commit**: [5511a69718e9d581386105705152592cee268e37](dotnet/source-build-reference-packages@5511a69) - **Branch**: [release/9.0](https://github.com/dotnet/source-build-reference-packages/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Updates**: - From [9.0.0-alpha.1.25473.1 to 9.0.0-alpha.1.25506.2][1] - Microsoft.SourceBuild.Intermediate.source-build-reference-packages [1]: dotnet/source-build-reference-packages@bd4018e...5511a69 [DependencyUpdate]: <> (End) [marker]: <> (End:3b2e34b4-9c9e-4da6-a358-02c0b764a22e) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…dotnet#120807) This pull request updates the following dependencies [marker]: <> (Begin:b458125c-6cf0-41ea-981d-2709b660d5c5) ## From https://github.com/dotnet/hotreload-utils - **Subscription**: [b458125c-6cf0-41ea-981d-2709b660d5c5](https://maestro.dot.net/subscriptions?search=b458125c-6cf0-41ea-981d-2709b660d5c5) - **Build**: [20251016.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2817702) ([287455](https://maestro.dot.net/channel/3883/github:dotnet:hotreload-utils/build/287455)) - **Date Produced**: October 16, 2025 3:16:33 PM UTC - **Commit**: [6190778452c8e5e7092aecd64679c0ce39f87529](dotnet/hotreload-utils@6190778) - **Branch**: [release/9.0](https://github.com/dotnet/hotreload-utils/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Updates**: - From [9.0.0-alpha.0.25504.3 to 9.0.0-alpha.0.25516.2][1] - Microsoft.DotNet.HotReload.Utils.Generator.BuildTool [1]: dotnet/hotreload-utils@d29a5b4...6190778 [DependencyUpdate]: <> (End) [marker]: <> (End:b458125c-6cf0-41ea-981d-2709b660d5c5) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…20782) This pull request updates the following dependencies [marker]: <> (Begin:b609d3b5-ab6f-473c-9ce1-f266baef16fc) ## From https://github.com/dotnet/cecil - **Subscription**: [b609d3b5-ab6f-473c-9ce1-f266baef16fc](https://maestro.dot.net/subscriptions?search=b609d3b5-ab6f-473c-9ce1-f266baef16fc) - **Build**: [20251015.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2816907) ([287281](https://maestro.dot.net/channel/3883/github:dotnet:cecil/build/287281)) - **Date Produced**: October 15, 2025 8:11:59 PM UTC - **Commit**: [805b6bcdc748e5b63ea01c05e70432b615db1b04](dotnet/cecil@805b6bc) - **Branch**: [release/9.0](https://github.com/dotnet/cecil/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Updates**: - From [0.11.5-alpha.25512.2 to 0.11.5-alpha.25515.2][1] - Microsoft.SourceBuild.Intermediate.cecil - Microsoft.DotNet.Cecil [1]: dotnet/cecil@9d04fe8...805b6bc [DependencyUpdate]: <> (End) [marker]: <> (End:b609d3b5-ab6f-473c-9ce1-f266baef16fc) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…otnet#120833) This pull request updates the following dependencies [marker]: <> (Begin:e06e39ae-771e-498d-7895-08dcbc301dc2) ## From https://github.com/dotnet/runtime-assets - **Subscription**: [e06e39ae-771e-498d-7895-08dcbc301dc2](https://maestro.dot.net/subscriptions?search=e06e39ae-771e-498d-7895-08dcbc301dc2) - **Build**: [20251016.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2817564) ([287436](https://maestro.dot.net/channel/3883/github:dotnet:runtime-assets/build/287436)) - **Date Produced**: October 16, 2025 10:51:23 AM UTC - **Commit**: [7ace84ca21dc53ca1e9c5d6f6d02b8245461eabf](dotnet/runtime-assets@7ace84c) - **Branch**: [release/9.0](https://github.com/dotnet/runtime-assets/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Updates**: - From [9.0.0-beta.25504.2 to 9.0.0-beta.25516.2][1] - Microsoft.DotNet.CilStrip.Sources - System.ComponentModel.TypeConverter.TestData - System.Data.Common.TestData - System.Drawing.Common.TestData - System.Formats.Tar.TestData - System.IO.Compression.TestData - System.IO.Packaging.TestData - System.Net.TestData - System.Private.Runtime.UnicodeData - System.Runtime.Numerics.TestData - System.Runtime.TimeZoneData - System.Security.Cryptography.X509Certificates.TestData - System.Text.RegularExpressions.TestData - System.Windows.Extensions.TestData [1]: dotnet/runtime-assets@a01a686...7ace84c [DependencyUpdate]: <> (End) [marker]: <> (End:e06e39ae-771e-498d-7895-08dcbc301dc2) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…19475) Backport of dotnet#117694 to release/9.0-staging /cc @jeffhandley @wfurt @ManickaP ## Customer Impact Related to dotnet#115502. Default AZL has firewall that blocks multicast. - [ ] Customer reported - [x] Found internally ## Regression - [ ] Yes - [x] No ## Testing This was verified in main and is also being backported to release/8.0-staging via dotnet#115502, to ensure the test doesn't fail in our baseline extra-platforms tests. ## Risk Low. Conditional test disablement. --------- Co-authored-by: wfurt <tweinfurt@yahoo.com> Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
Backport of dotnet#115951 to release/9.0-staging /cc @agocke @jkotas ## Customer Impact - [ ] Customer reported - [X] Found internally Newer versions of VS don't have the same versioning scheme as expected in these targets, so Native AOT will fail to find the native linker without this change (and will not be usable for targeting the NET 9 TFM). ## Regression - [X] Yes - [ ] No ## Testing Caught with the SDK tests, fix validated manually. ## Risk Low. Deletion of version check. Co-authored-by: Jan Kotas <jkotas@microsoft.com>
…et#120861) I detected changes in the release/9.0 branch which have not been merged yet to release/9.0-staging. I'm a robot and am configured to help you automatically keep release/9.0-staging up to date, so I've opened this PR. This PR merges commits made on release/9.0 by the following committers: * PranavSenthilnathan * dotnet-maestro[bot] ## Instructions for merging from UI This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, *not* a squash or rebase commit. <img alt="merge button instructions" src="https://i.imgur.com/GepcNJV.png" width="300" /> If this repo does not allow creating merge commits from the GitHub UI, use command line instructions. ## Instructions for merging via command line Run these commands to merge this pull request from the command line. ``` sh git fetch git checkout release/9.0 git pull --ff-only git checkout release/9.0-staging git pull --ff-only git merge --no-ff release/9.0 # If there are merge conflicts, resolve them and then run git merge --continue to complete the merge # Pushing the changes to the PR branch will re-trigger PR validation. git push https://github.com/dotnet/runtime HEAD:merge/release/9.0-to-release/9.0-staging ``` <details> <summary>or if you are using SSH</summary> ``` git push git@github.com:dotnet/runtime HEAD:merge/release/9.0-to-release/9.0-staging ``` </details> After PR checks are complete push the branch ``` git push ``` ## Instructions for resolving conflicts :warning: If there are merge conflicts, you will need to resolve them manually before merging. You can do this [using GitHub][resolve-github] or using the [command line][resolve-cli]. [resolve-github]: https://help.github.com/articles/resolving-a-merge-conflict-on-github/ [resolve-cli]: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ ## Instructions for updating this pull request Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/9.0-to-release/9.0-staging'. This can be done to resolve conflicts or make other changes to this pull request before it is merged. The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote. ``` git fetch git checkout -b merge/release/9.0-to-release/9.0-staging origin/release/9.0-staging git pull https://github.com/dotnet/runtime merge/release/9.0-to-release/9.0-staging (make changes) git commit -m "Updated PR with my changes" git push https://github.com/dotnet/runtime HEAD:merge/release/9.0-to-release/9.0-staging ``` <details> <summary>or if you are using SSH</summary> ``` git fetch git checkout -b merge/release/9.0-to-release/9.0-staging origin/release/9.0-staging git pull git@github.com:dotnet/runtime merge/release/9.0-to-release/9.0-staging (make changes) git commit -m "Updated PR with my changes" git push git@github.com:dotnet/runtime HEAD:merge/release/9.0-to-release/9.0-staging ``` </details> Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues. Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.
…t#120764) This pull request updates the following dependencies [marker]: <> (Begin:077f423f-1332-4108-a2ea-08dcc66548e6) ## From https://github.com/dotnet/xharness - **Subscription**: [077f423f-1332-4108-a2ea-08dcc66548e6](https://maestro.dot.net/subscriptions?search=077f423f-1332-4108-a2ea-08dcc66548e6) - **Build**: [20251017.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2818377) ([287580](https://maestro.dot.net/channel/5175/github:dotnet:xharness/build/287580)) - **Date Produced**: October 17, 2025 9:34:42 AM UTC - **Commit**: [6717f7d268fc03a524a6834eb9a154b6b3a9da9a](dotnet/xharness@6717f7d) - **Branch**: [release/9.0](https://github.com/dotnet/xharness/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Updates**: - From [9.0.0-prerelease.25504.2 to 9.0.0-prerelease.25517.1][3] - Microsoft.DotNet.XHarness.CLI - Microsoft.DotNet.XHarness.TestRunners.Common - Microsoft.DotNet.XHarness.TestRunners.Xunit [3]: dotnet/xharness@47324ca...6717f7d [DependencyUpdate]: <> (End) [marker]: <> (End:077f423f-1332-4108-a2ea-08dcc66548e6) --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…20926) This pull request updates the following dependencies [marker]: <> (Begin:b609d3b5-ab6f-473c-9ce1-f266baef16fc) ## From https://github.com/dotnet/cecil - **Subscription**: [b609d3b5-ab6f-473c-9ce1-f266baef16fc](https://maestro.dot.net/subscriptions?search=b609d3b5-ab6f-473c-9ce1-f266baef16fc) - **Build**: [20251026.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2825233) ([288658](https://maestro.dot.net/channel/3883/github:dotnet:cecil/build/288658)) - **Date Produced**: October 27, 2025 5:37:54 AM UTC - **Commit**: [4f28ab4904dcefea3464d910ffaf2cdc3067496a](dotnet/cecil@4f28ab4) - **Branch**: [release/9.0](https://github.com/dotnet/cecil/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Updates**: - From [0.11.5-alpha.25515.2 to 0.11.5-alpha.25526.1][2] - Microsoft.SourceBuild.Intermediate.cecil - Microsoft.DotNet.Cecil [2]: dotnet/cecil@805b6bc...4f28ab4 [DependencyUpdate]: <> (End) [marker]: <> (End:b609d3b5-ab6f-473c-9ce1-f266baef16fc) --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Andy Gocke <angocke@microsoft.com>
) This pull request updates the following dependencies [marker]: <> (Begin:5e3f9b88-faad-436c-a580-ac009d20bb33) ## From https://github.com/dotnet/icu - **Subscription**: [5e3f9b88-faad-436c-a580-ac009d20bb33](https://maestro.dot.net/subscriptions?search=5e3f9b88-faad-436c-a580-ac009d20bb33) - **Build**: [20251030.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2827690) ([289015](https://maestro.dot.net/channel/3883/github:dotnet:icu/build/289015)) - **Date Produced**: October 30, 2025 10:58:07 AM UTC - **Commit**: [76f42e5d2c84cb2358793ef33826bc65140ee3fb](dotnet/icu@76f42e5) - **Branch**: [dotnet/release/9.0](https://github.com/dotnet/icu/tree/dotnet/release/9.0) [DependencyUpdate]: <> (Begin) - **Updates**: - From [9.0.0-rtm.25511.1 to 9.0.0-rtm.25530.1][7] - Microsoft.NETCore.Runtime.ICU.Transport [7]: dotnet/icu@9277e62...76f42e5 [DependencyUpdate]: <> (End) [marker]: <> (End:5e3f9b88-faad-436c-a580-ac009d20bb33) --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…idge optimization (dotnet#121376) Backport of dotnet#121243 to release/9.0-staging /cc @BrzVlad ## Customer Impact - [x] Customer reported - [ ] Found internally Applications on maui-android can randomly crash during GC. We've had a few fixes for the tarjan bridge merged a few months ago, but there is still one more issue. The problem is caused by a specific optimization inside the tarjan gc bridge. The only workaround for a customer hitting this failure is to configure an environment variable so that their app uses a different gc bridge (which has worse performance). One customer reported that using the older gc bridge makes the application unusable due to degradation of performance. This PR allows users to opt out of a smaller optimization and keep using the tarjan gc bridge, as a workaround for .NET9. ## Regression - [ ] Yes - [x] No ## Testing Tested on our own gc bridge tests, with scenario causing the issue. ## Risk This PR has zero risk since it just adds support for disabling an optimization. By default, there is no change in behavior. I plan to backport to .NET10 the actual fix for this issue. --------- Co-authored-by: Vlad Brezae <brezaevlad@gmail.com>
…121426) Backport of dotnet#120696 to release/9.0-staging /cc @akoeplinger ## Customer Impact - [ ] Customer reported - [X] Found internally no customer impact, this affects our internal builds due to CFS restrictions. ## Regression - [ ] Yes - [X] No ## Testing Tested in CI. ## Risk None. This just changes a setting for nuget package restore. **IMPORTANT**: If this backport is for a servicing release, please verify that: - For .NET 8 and .NET 9: The PR target branch is `release/X.0-staging`, not `release/X.0`. - For .NET 10+: The PR target branch is `release/X.0` (no `-staging` suffix). ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
…121430) This pull request updates the following dependencies [marker]: <> (Begin:943c2154-7e47-4fed-bb40-3e772747daf7) ## From https://github.com/dotnet/arcade - **Subscription**: [943c2154-7e47-4fed-bb40-3e772747daf7](https://maestro.dot.net/subscriptions?search=943c2154-7e47-4fed-bb40-3e772747daf7) - **Build**: [20251105.4](https://dev.azure.com/dnceng/internal/_build/results?buildId=2832013) ([289663](https://maestro.dot.net/channel/5175/github:dotnet:arcade/build/289663)) - **Date Produced**: November 5, 2025 7:38:32 PM UTC - **Commit**: [9eaf7b289d5003a94ee23658f057a6c06ddcd570](dotnet/arcade@9eaf7b2) - **Branch**: [release/9.0](https://github.com/dotnet/arcade/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Updates**: - From [9.0.0-beta.25515.2 to 9.0.0-beta.25555.4][1] - Microsoft.SourceBuild.Intermediate.arcade - Microsoft.DotNet.Arcade.Sdk - Microsoft.DotNet.Build.Tasks.Archives - Microsoft.DotNet.Build.Tasks.Feed - Microsoft.DotNet.Build.Tasks.Installers - Microsoft.DotNet.Build.Tasks.Packaging - Microsoft.DotNet.Build.Tasks.TargetFramework - Microsoft.DotNet.Build.Tasks.Templating - Microsoft.DotNet.Build.Tasks.Workloads - Microsoft.DotNet.CodeAnalysis - Microsoft.DotNet.GenAPI - Microsoft.DotNet.GenFacades - Microsoft.DotNet.Helix.Sdk - Microsoft.DotNet.PackageTesting - Microsoft.DotNet.RemoteExecutor - Microsoft.DotNet.SharedFramework.Sdk - Microsoft.DotNet.VersionTools.Tasks - Microsoft.DotNet.XliffTasks - Microsoft.DotNet.XUnitExtensions - From [2.9.0-beta.25515.2 to 2.9.0-beta.25555.4][1] - Microsoft.DotNet.XUnitAssert - Microsoft.DotNet.XUnitConsoleRunner [1]: dotnet/arcade@6666973...9eaf7b2 [DependencyUpdate]: <> (End) - **Updates to .NET SDKs in root:** - Updates sdk.version to 9.0.111 - Updates tools.dotnet to 9.0.111 [marker]: <> (End:943c2154-7e47-4fed-bb40-3e772747daf7) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…21516) This pull request updates the following dependencies [marker]: <> (Begin:b609d3b5-ab6f-473c-9ce1-f266baef16fc) ## From https://github.com/dotnet/cecil - **Subscription**: [b609d3b5-ab6f-473c-9ce1-f266baef16fc](https://maestro.dot.net/subscriptions?search=b609d3b5-ab6f-473c-9ce1-f266baef16fc) - **Build**: [20251109.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2835062) ([290106](https://maestro.dot.net/channel/3883/github:dotnet:cecil/build/290106)) - **Date Produced**: November 10, 2025 5:44:32 AM UTC - **Commit**: [6f2435da56379f9542c90e27ced6c103067cd875](dotnet/cecil@6f2435d) - **Branch**: [release/9.0](https://github.com/dotnet/cecil/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [0.11.5-alpha.25526.1 to 0.11.5-alpha.25559.3][1] - Microsoft.SourceBuild.Intermediate.cecil - Microsoft.DotNet.Cecil [1]: dotnet/cecil@4f28ab4...6f2435d [DependencyUpdate]: <> (End) [marker]: <> (End:b609d3b5-ab6f-473c-9ce1-f266baef16fc) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…0.0 (dotnet#121151) ## Customer Impact - [x] Customer reported - [ ] Found internally These issues were reported in dotnet#119706 as problems with clang-21 on Fedora 43. The investigation uncovered that clang introduced a potentially breaking change in clang-20 that we do not currently consume. These build changes impact VMR related builds when linux distrobutions performing source build adopt clang-21. clang-20 breaking change log - https://releases.llvm.org/20.1.0/tools/clang/docs/ReleaseNotes.html#potentially-breaking-changes. This PR contains the minimal changes needed to fix issues from the following PR dotnet#120775. .NET 10: dotnet#121124 .NET 8: dotnet#121150 ## Regression - [ ] Yes - [x] No Build with the new clang-21 compiler will cause the runtime to crash. ## Testing This has been validated using various legs and examples to demonstrate the usage of undefined behavior these flags convert into "defined" behavior in C/C++. ## Risk Low. This has zero impact on our production build since we specifically target clang-18. This is only valid for those partners that are using clang-20+.
…21606) This pull request updates the following dependencies [marker]: <> (Begin:b609d3b5-ab6f-473c-9ce1-f266baef16fc) ## From https://github.com/dotnet/cecil - **Subscription**: [b609d3b5-ab6f-473c-9ce1-f266baef16fc](https://maestro.dot.net/subscriptions?search=b609d3b5-ab6f-473c-9ce1-f266baef16fc) - **Build**: [20251113.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2838193) ([290681](https://maestro.dot.net/channel/3883/github:dotnet:cecil/build/290681)) - **Date Produced**: November 13, 2025 6:50:34 PM UTC - **Commit**: [0b1a2e363a2e54e3e31e88672b6def6d86164c5d](dotnet/cecil@0b1a2e3) - **Branch**: [release/9.0](https://github.com/dotnet/cecil/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [0.11.5-alpha.25559.3 to 0.11.5-alpha.25563.2][1] - Microsoft.SourceBuild.Intermediate.cecil - Microsoft.DotNet.Cecil [1]: dotnet/cecil@6f2435d...0b1a2e3 [DependencyUpdate]: <> (End) [marker]: <> (End:b609d3b5-ab6f-473c-9ce1-f266baef16fc) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…121568) This pull request updates the following dependencies [marker]: <> (Begin:60694bfc-fbc6-40d6-af1a-4c5dac51a701) ## From https://github.com/dotnet/roslyn - **Subscription**: [60694bfc-fbc6-40d6-af1a-4c5dac51a701](https://maestro.dot.net/subscriptions?search=60694bfc-fbc6-40d6-af1a-4c5dac51a701) - **Build**: [20251111.11](https://dev.azure.com/dnceng/internal/_build/results?buildId=2836753) ([290456](https://maestro.dot.net/channel/4906/github:dotnet:roslyn/build/290456)) - **Date Produced**: November 12, 2025 9:26:18 AM UTC - **Commit**: [272651916acd264189724508f884596017e84afc](dotnet/roslyn@2726519) - **Branch**: [release/dev17.12](https://github.com/dotnet/roslyn/tree/release/dev17.12) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [4.12.0-3.25467.18 to 4.12.0-3.25561.11][1] - Microsoft.SourceBuild.Intermediate.roslyn - Microsoft.CodeAnalysis - Microsoft.CodeAnalysis.CSharp - Microsoft.Net.Compilers.Toolset [1]: dotnet/roslyn@dcf9af2...2726519 [DependencyUpdate]: <> (End) [marker]: <> (End:60694bfc-fbc6-40d6-af1a-4c5dac51a701) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ference-packages (dotnet#121592) This pull request updates the following dependencies [marker]: <> (Begin:3b2e34b4-9c9e-4da6-a358-02c0b764a22e) ## From https://github.com/dotnet/source-build-reference-packages - **Subscription**: [3b2e34b4-9c9e-4da6-a358-02c0b764a22e](https://maestro.dot.net/subscriptions?search=3b2e34b4-9c9e-4da6-a358-02c0b764a22e) - **Build**: [20251021.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2821250) ([287993](https://maestro.dot.net/channel/5175/github:dotnet:source-build-reference-packages/build/287993)) - **Date Produced**: October 21, 2025 4:49:11 PM UTC - **Commit**: [a9cadb09ddcc99b1e535efb0648047634f0c4f40](dotnet/source-build-reference-packages@a9cadb0) - **Branch**: [release/9.0](https://github.com/dotnet/source-build-reference-packages/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [9.0.0-alpha.1.25517.3 to 9.0.0-alpha.1.25521.3][1] - Microsoft.SourceBuild.Intermediate.source-build-reference-packages [1]: dotnet/source-build-reference-packages@2621104...a9cadb0 [DependencyUpdate]: <> (End) [marker]: <> (End:3b2e34b4-9c9e-4da6-a358-02c0b764a22e) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…properties are involved (dotnet#119404)
…otnet#117891) Backport of dotnet#117627 to release/9.0-staging /cc @thaystg ## Customer Impact - [ ] Customer reported - [X] Found internally We initially backported this change to 10, but held off because there were no reported issues with .NET 9. That has changed with https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2604939 where we were able to reproduce the issue. The change fixes a crash in debugger by adding a null check around TLS data before dereferencing a pointer. ## Regression - [ ] Yes - [X] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing Manually tested a default iOS SDK application ## Risk Low **IMPORTANT**: If this backport is for a servicing release, please verify that: - The PR target branch is `release/X.0-staging`, not `release/X.0`. ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. Co-authored-by: Thays Grazia <thaystg@gmail.com> Co-authored-by: Larry Ewing <lewing@microsoft.com>
…21725) This pull request updates the following dependencies [marker]: <> (Begin:b609d3b5-ab6f-473c-9ce1-f266baef16fc) ## From https://github.com/dotnet/cecil - **Subscription**: [b609d3b5-ab6f-473c-9ce1-f266baef16fc](https://maestro.dot.net/subscriptions?search=b609d3b5-ab6f-473c-9ce1-f266baef16fc) - **Build**: [20251116.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2840716) ([291085](https://maestro.dot.net/channel/3883/github:dotnet:cecil/build/291085)) - **Date Produced**: November 17, 2025 5:40:30 AM UTC - **Commit**: [60faa90ec95fd499f8aba4b7d212da1993b7ee15](dotnet/cecil@60faa90) - **Branch**: [release/9.0](https://github.com/dotnet/cecil/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [0.11.5-alpha.25563.2 to 0.11.5-alpha.25566.3][1] - Microsoft.SourceBuild.Intermediate.cecil - Microsoft.DotNet.Cecil [1]: dotnet/cecil@0b1a2e3...60faa90 [DependencyUpdate]: <> (End) [marker]: <> (End:b609d3b5-ab6f-473c-9ce1-f266baef16fc) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…121724) This pull request updates the following dependencies [marker]: <> (Begin:60694bfc-fbc6-40d6-af1a-4c5dac51a701) ## From https://github.com/dotnet/roslyn - **Subscription**: [60694bfc-fbc6-40d6-af1a-4c5dac51a701](https://maestro.dot.net/subscriptions?search=60694bfc-fbc6-40d6-af1a-4c5dac51a701) - **Build**: [20251119.8](https://dev.azure.com/dnceng/internal/_build/results?buildId=2842956) ([291511](https://maestro.dot.net/channel/4906/github:dotnet:roslyn/build/291511)) - **Date Produced**: November 19, 2025 8:53:26 PM UTC - **Commit**: [dc344ef24932dcd53cdd24c15364a5996bc6a675](dotnet/roslyn@dc344ef) - **Branch**: [release/dev17.12](https://github.com/dotnet/roslyn/tree/release/dev17.12) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [4.12.0-3.25561.11 to 4.12.0-3.25569.8][2] - Microsoft.SourceBuild.Intermediate.roslyn - Microsoft.CodeAnalysis - Microsoft.CodeAnalysis.CSharp - Microsoft.Net.Compilers.Toolset [2]: dotnet/roslyn@2726519...dc344ef [DependencyUpdate]: <> (End) [marker]: <> (End:60694bfc-fbc6-40d6-af1a-4c5dac51a701) --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…t#121693) This pull request updates the following dependencies [marker]: <> (Begin:077f423f-1332-4108-a2ea-08dcc66548e6) ## From https://github.com/dotnet/xharness - **Subscription**: [077f423f-1332-4108-a2ea-08dcc66548e6](https://maestro.dot.net/subscriptions?search=077f423f-1332-4108-a2ea-08dcc66548e6) - **Build**: [20251114.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2839020) ([290899](https://maestro.dot.net/channel/5175/github:dotnet:xharness/build/290899)) - **Date Produced**: November 14, 2025 2:20:00 PM UTC - **Commit**: [bb1cfc0c870d5b50cfd9795251e44f244e6a3f45](dotnet/xharness@bb1cfc0) - **Branch**: [release/9.0](https://github.com/dotnet/xharness/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [9.0.0-prerelease.25517.1 to 9.0.0-prerelease.25564.2][1] - Microsoft.DotNet.XHarness.CLI - Microsoft.DotNet.XHarness.TestRunners.Common - Microsoft.DotNet.XHarness.TestRunners.Xunit [1]: dotnet/xharness@6717f7d...bb1cfc0 [DependencyUpdate]: <> (End) [marker]: <> (End:077f423f-1332-4108-a2ea-08dcc66548e6) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…otnet#121677) This pull request updates the following dependencies [marker]: <> (Begin:e06e39ae-771e-498d-7895-08dcbc301dc2) ## From https://github.com/dotnet/runtime-assets - **Subscription**: [e06e39ae-771e-498d-7895-08dcbc301dc2](https://maestro.dot.net/subscriptions?search=e06e39ae-771e-498d-7895-08dcbc301dc2) - **Build**: [20251115.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2839871) ([291017](https://maestro.dot.net/channel/3883/github:dotnet:runtime-assets/build/291017)) - **Date Produced**: November 15, 2025 4:49:22 PM UTC - **Commit**: [91ea918f8fb26ec1d290283e5c5eeb1b003113da](dotnet/runtime-assets@91ea918) - **Branch**: [release/9.0](https://github.com/dotnet/runtime-assets/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [9.0.0-beta.25516.2 to 9.0.0-beta.25565.2][1] - Microsoft.DotNet.CilStrip.Sources - System.ComponentModel.TypeConverter.TestData - System.Data.Common.TestData - System.Drawing.Common.TestData - System.Formats.Tar.TestData - System.IO.Compression.TestData - System.IO.Packaging.TestData - System.Net.TestData - System.Private.Runtime.UnicodeData - System.Runtime.Numerics.TestData - System.Runtime.TimeZoneData - System.Security.Cryptography.X509Certificates.TestData - System.Text.RegularExpressions.TestData - System.Windows.Extensions.TestData [1]: dotnet/runtime-assets@7ace84c...91ea918 [DependencyUpdate]: <> (End) [marker]: <> (End:e06e39ae-771e-498d-7895-08dcbc301dc2) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…dotnet#121663) This pull request updates the following dependencies [marker]: <> (Begin:b458125c-6cf0-41ea-981d-2709b660d5c5) ## From https://github.com/dotnet/hotreload-utils - **Subscription**: [b458125c-6cf0-41ea-981d-2709b660d5c5](https://maestro.dot.net/subscriptions?search=b458125c-6cf0-41ea-981d-2709b660d5c5) - **Build**: [20251115.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2839875) ([291016](https://maestro.dot.net/channel/3883/github:dotnet:hotreload-utils/build/291016)) - **Date Produced**: November 15, 2025 4:39:42 PM UTC - **Commit**: [6e573ac4b374c5a60c364396b1e94d648f1f8245](dotnet/hotreload-utils@6e573ac) - **Branch**: [release/9.0](https://github.com/dotnet/hotreload-utils/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [9.0.0-alpha.0.25516.2 to 9.0.0-alpha.0.25565.2][1] - Microsoft.DotNet.HotReload.Utils.Generator.BuildTool [1]: dotnet/hotreload-utils@6190778...6e573ac [DependencyUpdate]: <> (End) [marker]: <> (End:b458125c-6cf0-41ea-981d-2709b660d5c5) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
) This pull request updates the following dependencies [marker]: <> (Begin:5e3f9b88-faad-436c-a580-ac009d20bb33) ## From https://github.com/dotnet/icu - **Subscription**: [5e3f9b88-faad-436c-a580-ac009d20bb33](https://maestro.dot.net/subscriptions?search=5e3f9b88-faad-436c-a580-ac009d20bb33) - **Build**: [20251124.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2846433) ([292103](https://maestro.dot.net/channel/3883/github:dotnet:icu/build/292103)) - **Date Produced**: November 24, 2025 4:37:47 PM UTC - **Commit**: [e18dd5d9e047367be7486ab66636b892cbe24a67](dotnet/icu@e18dd5d) - **Branch**: [dotnet/release/9.0](https://github.com/dotnet/icu/tree/dotnet/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [9.0.0-rtm.25565.2 to 9.0.0-rtm.25574.1][1] - Microsoft.NETCore.Runtime.ICU.Transport [1]: dotnet/icu@e3a37f4...e18dd5d [DependencyUpdate]: <> (End) [marker]: <> (End:5e3f9b88-faad-436c-a580-ac009d20bb33) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…tnet#120838) Backport of dotnet#120736 to release/9.0-staging /cc @rzikm ## Customer Impact None, the change is in Debug build only and doesn't affect shipped product. ## Regression No, test failures started after adding/updating AzureLinux3 OS in CI matrix. ## Testing CI passes. ## Risk Low, can be considered test-only change as the changes don't propagate to shipped product. --------- Co-authored-by: Radek Zikmund <r.zikmund.rz@gmail.com>
…dotnet#121928) This pull request updates the following dependencies [marker]: <> (Begin:b458125c-6cf0-41ea-981d-2709b660d5c5) ## From https://github.com/dotnet/hotreload-utils - **Subscription**: [b458125c-6cf0-41ea-981d-2709b660d5c5](https://maestro.dot.net/subscriptions?search=b458125c-6cf0-41ea-981d-2709b660d5c5) - **Build**: [20251124.4](https://dev.azure.com/dnceng/internal/_build/results?buildId=2846458) ([292102](https://maestro.dot.net/channel/3883/github:dotnet:hotreload-utils/build/292102)) - **Date Produced**: November 24, 2025 4:29:47 PM UTC - **Commit**: [81fc6af21b4133b2a5c5be0e6dc38b58048e732d](dotnet/hotreload-utils@81fc6af) - **Branch**: [release/9.0](https://github.com/dotnet/hotreload-utils/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [9.0.0-alpha.0.25565.2 to 9.0.0-alpha.0.25574.4][1] - Microsoft.DotNet.HotReload.Utils.Generator.BuildTool [1]: dotnet/hotreload-utils@6e573ac...81fc6af [DependencyUpdate]: <> (End) [marker]: <> (End:b458125c-6cf0-41ea-981d-2709b660d5c5) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…t#121908) This pull request updates the following dependencies [marker]: <> (Begin:077f423f-1332-4108-a2ea-08dcc66548e6) ## From https://github.com/dotnet/xharness - **Subscription**: [077f423f-1332-4108-a2ea-08dcc66548e6](https://maestro.dot.net/subscriptions?search=077f423f-1332-4108-a2ea-08dcc66548e6) - **Build**: [20251120.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2843478) ([291594](https://maestro.dot.net/channel/5175/github:dotnet:xharness/build/291594)) - **Date Produced**: November 20, 2025 9:39:09 AM UTC - **Commit**: [3e74b96870050adc82beed3934abf93d40716012](dotnet/xharness@3e74b96) - **Branch**: [release/9.0](https://github.com/dotnet/xharness/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [9.0.0-prerelease.25564.2 to 9.0.0-prerelease.25570.2][1] - Microsoft.DotNet.XHarness.CLI - Microsoft.DotNet.XHarness.TestRunners.Common - Microsoft.DotNet.XHarness.TestRunners.Xunit [1]: dotnet/xharness@bb1cfc0...3e74b96 [DependencyUpdate]: <> (End) [marker]: <> (End:077f423f-1332-4108-a2ea-08dcc66548e6) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Sam Patel <46026722+SamMonoRT@users.noreply.github.com>
…et#121388) I detected changes in the release/9.0 branch which have not been merged yet to release/9.0-staging. I'm a robot and am configured to help you automatically keep release/9.0-staging up to date, so I've opened this PR. This PR merges commits made on release/9.0 by the following committers: * vseanreesermsft * dotnet-maestro[bot] ## Instructions for merging from UI This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, *not* a squash or rebase commit. <img alt="merge button instructions" src="https://i.imgur.com/GepcNJV.png" width="300" /> If this repo does not allow creating merge commits from the GitHub UI, use command line instructions. ## Instructions for merging via command line Run these commands to merge this pull request from the command line. ``` sh git fetch git checkout release/9.0 git pull --ff-only git checkout release/9.0-staging git pull --ff-only git merge --no-ff release/9.0 # If there are merge conflicts, resolve them and then run git merge --continue to complete the merge # Pushing the changes to the PR branch will re-trigger PR validation. git push https://github.com/dotnet/runtime HEAD:merge/release/9.0-to-release/9.0-staging ``` <details> <summary>or if you are using SSH</summary> ``` git push git@github.com:dotnet/runtime HEAD:merge/release/9.0-to-release/9.0-staging ``` </details> After PR checks are complete push the branch ``` git push ``` ## Instructions for resolving conflicts :warning: If there are merge conflicts, you will need to resolve them manually before merging. You can do this [using GitHub][resolve-github] or using the [command line][resolve-cli]. [resolve-github]: https://help.github.com/articles/resolving-a-merge-conflict-on-github/ [resolve-cli]: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ ## Instructions for updating this pull request Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/9.0-to-release/9.0-staging'. This can be done to resolve conflicts or make other changes to this pull request before it is merged. The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote. ``` git fetch git checkout -b merge/release/9.0-to-release/9.0-staging origin/release/9.0-staging git pull https://github.com/dotnet/runtime merge/release/9.0-to-release/9.0-staging (make changes) git commit -m "Updated PR with my changes" git push https://github.com/dotnet/runtime HEAD:merge/release/9.0-to-release/9.0-staging ``` <details> <summary>or if you are using SSH</summary> ``` git fetch git checkout -b merge/release/9.0-to-release/9.0-staging origin/release/9.0-staging git pull git@github.com:dotnet/runtime merge/release/9.0-to-release/9.0-staging (make changes) git commit -m "Updated PR with my changes" git push git@github.com:dotnet/runtime HEAD:merge/release/9.0-to-release/9.0-staging ``` </details> Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues. Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR merges changes from release/9.0-staging into release/9.0, primarily focused on removing NodeJS test support from WASM infrastructure and updating test certificates.
Key Changes
- Complete removal of NodeJS as a WASM test host across test infrastructure, build scripts, and documentation
- Update of Microsoft.com SSL certificate test data with new certificate (validity: 2025-10-01 to 2026-03-30)
- Removal of Blazor_net50 test assets
- Dependency version updates (Arcade SDKs, Roslyn, XHarness, runtime assets)
- Bug fixes in CoreCLR debugger, Mono GC, and platform-specific code
Reviewed changes
Copilot reviewed 53 out of 55 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eng/testing/WasmRunnerTemplate.cmd | NodeJS test scenario removal, missing module flag |
| eng/testing/WasmRunnerTemplate.sh | NodeJS test scenario removal |
| eng/testing/tests.browser.targets | NodeJS scenario and NPM handling removal |
| src/libraries/sendtohelix-browser.targets | NodeJS scenario removal from library tests |
| src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs | Removed NodeJS enum value |
| src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs | Removed NodeJS host runner mapping |
| src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs | File deleted |
| src/mono/wasm/features.md | Documentation updates removing NodeJS references |
| src/libraries/System.Security.Cryptography/tests/X509Certificates/TestData.cs | Updated SSL certificate test data |
| src/libraries/System.Security.Cryptography/tests/X509Certificates/MatchesHostnameTests.cs | Updated hostname test cases for new certificate |
| src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs | Updated verification times and platform-specific logic |
| src/libraries/System.Security.Cryptography/tests/X509Certificates/CollectionTests.cs | Updated verification time |
| src/libraries/System.Security.Cryptography/tests/X509Certificates/ExtensionsTests/AuthorityKeyIdentifierTests.cs | Updated expected certificate data |
| src/coreclr/debug/di/rsthread.cpp | Fixed user state type casting and whitespace |
| src/coreclr/debug/di/rspriv.h | Changed m_userState from CorDebugUserState to int |
| src/mono/mono/metadata/sgen-tarjan-bridge.c | Fixed loop counter increment location |
| src/mono/mono/metadata/sgen-bridge.c | Added disable-non-bridge-scc parameter |
| src/mono/mono/component/debugger-agent.c | Added null check for tls pointer |
| src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs | Adjusted debug assert for 0-length files |
| src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/Analyzers/ConvertComImportToGeneratedComInterfaceAnalyzer.cs | Filter out property/event accessors |
| src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ConvertToGeneratedComInterfaceTests.cs | Added test cases for properties and events |
| src/coreclr/nativeaot/BuildIntegration/findvcvarsall.bat | Removed VS version constraint |
| eng/native/configurecompiler.cmake | Added Clang 20+ overflow handling flags |
| global.json | Updated Arcade SDK versions |
| eng/Versions.props | Updated dependency versions |
| eng/Version.Details.xml | Updated dependency SHAs |
| NuGet.config | Removed audit sources configuration |
| .config/dotnet-tools.json | Updated XHarness CLI version |
| eng/pipelines/runtime.yml | Removed commented NodeJS scenario |
| eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml | Removed NodeJS test job templates |
| src/libraries/*.csproj (multiple) | Updated TestArchiveTestsRoot from browserornodejs to browseronly |
| src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs | Consolidated multicast test platform checks |
| src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props | Removed NodeJS TLS configuration |
| src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets | Removed NodeJS scenario |
| src/mono/wasm/testassets/Blazor_net50/* (all files) | Entire directory deleted |
This was referenced Dec 6, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.