Update emsdk to last 3.1.* version #1570
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
previously requested changes
Dec 18, 2025
Member
mthalman
left a comment
mthalman
left a comment
There was a problem hiding this comment.
The failed build shows that it's also failing for Windows 2022 so that Dockerfile should be updated too. Here are all the emscripten version references: https://github.com/search?q=repo%3Adotnet%2Fdotnet-buildtools-prereqs-docker%203.1.34&type=code. I think they should all be updated to the same version for consistency.
mthalman
reviewed
Dec 19, 2025
Member
mthalman
left a comment
mthalman
left a comment
There was a problem hiding this comment.
I'll be out for the year after today. So I'm changing my review state to not block this PR if updates are made.
mthalman
dismissed
their stale review
I'll be out for the year after today. So I'm changing my review state to not block this PR if updates are made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://dev.azure.com/dnceng/internal/_build/results?buildId=2862943&view=logs&j=ac6b6821-8acd-5984-7655-f2383ed475ef&t=923b5c46-be3b-57c2-368a-64e3353d204b&s=ff05ad62-bb9a-53b6-ce9f-72f329a63e7c.
Tested in https://dev.azure.com/dnceng/internal/_build/results?buildId=2863500&view=results