Add .npmrc next to package.json #13358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .npmrc is not transitively looked up in parent directories like other config files, it needs to be next to the package.json Also remove the always-auth entry since it is deprecated/unused in npm and will be removed: actions/setup-node#1305
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13358Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13358" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses SFI network isolation requirements by ensuring .npmrc configuration files are co-located with package.json files throughout the repository. The changes remove the deprecated always-auth setting and ensure consistent npm registry configuration.
- Adds
.npmrcfiles with registry configuration to all project directories containingpackage.jsonfiles - Removes deprecated
always-authconfiguration entries from existing.npmrcfiles - Cleans up whitespace in the extension
.npmrcfile
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.ProjectTemplates/templates/aspire-py-starter/frontend/.npmrc | Adds registry configuration next to package.json for Python starter template |
| src/Aspire.ProjectTemplates/templates/aspire-js-frontend-starter/frontend/.npmrc | Adds registry configuration next to package.json for JS frontend starter template |
| playground/BrowserTelemetry/BrowserTelemetry.Web/.npmrc | Adds registry configuration next to package.json for BrowserTelemetry playground |
| playground/AspireWithNode/NodeFrontend/.npmrc | Adds registry configuration to existing .npmrc with engine-strict setting |
| playground/AspireWithJavaScript/AspireJavaScript.Vue/.npmrc | Adds registry configuration next to package.json for Vue playground |
| playground/AspireWithJavaScript/AspireJavaScript.Vite/.npmrc | Adds registry configuration next to package.json for Vite playground |
| playground/AspireWithJavaScript/AspireJavaScript.React/.npmrc | Adds registry configuration next to package.json for React playground |
| playground/AspireWithJavaScript/AspireJavaScript.NodeApp/.npmrc | Adds registry configuration next to package.json for NodeApp playground |
| playground/AspireWithJavaScript/AspireJavaScript.Angular/.npmrc | Adds registry configuration next to package.json for Angular playground |
| extension/.npmrc | Removes deprecated always-auth setting and trailing whitespace |
| .npmrc | Removes deprecated always-auth setting from root configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .npmrc is not transitively looked up in parent directories like other config files, it needs to be next to the package.json
Also remove the always-auth entry since it is deprecated/unused in npm and will be removed: actions/setup-node#1305
This fixes the registry.npmjs.org related violations for SFI network isolation, it needs to be backported to all active branches.