Skip to content

Try to preserve the app cache on uninstall. #10019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dellis1972 wants to merge 4 commits into from
Closed

Try to preserve the app cache on uninstall. #10019

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03cebe9
Try to preserve the app cache on uninstall.
dellis1972 Apr 9, 2025
34f59f6
Just use pm uninstall
dellis1972 Apr 26, 2025
6fcb64c
Update Xamarin.Android.Common.targets
jonathanpeppers May 5, 2025
3ab8c57
Update Xamarin.Android.Common.targets
jonathanpeppers May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2988,18 +2988,20 @@ because xbuild doesn't support framework reference assemblies.
<Target Name="_DeployAppBundle"
Condition=" '$(AndroidPackageFormat)' == 'aab' "
DependsOnTargets="_BuildApkSet">
<!-- The previous attempt failed. So yry to uninstall but save the cache using cmd package uninstall -k -->
<AndroidAdb
Condition=" '$(EmbedAssembliesIntoApk)' == 'true' "
ContinueOnError="True"
ToolExe="$(AdbToolExe)"
ToolPath="$(AdbToolPath)"
AdbTarget="$(AdbTarget)"
Command="uninstall"
Arguments="-k $(_AndroidPackage)"
Command="shell cmd package uninstall -k"
Copy link
Contributor

@jonpryor jonpryor May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should instead be adb shell pm uninstall -k PACKAGE.

Copy link
Contributor

@jonpryor jonpryor May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…as I'd never heard of adb shell cmd before now, and it's not listed at e.g. <adbshell.com>.

Copy link
Member

@jonathanpeppers jonathanpeppers May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice it's doing adb shell cmd package uninstall -k.

android-platform-support looked like it was doing adb shell pm uninstall -k, so let me just change to that and let's see what CI says?

Arguments="$(_AndroidPackage)"
>
<Output TaskParameter="Result" PropertyName="_UninstallResult" />
</AndroidAdb>
<AndroidAdb
<!-- adb really can't uninstall this app with the cache intact, we need to completely uninstall it. -->
<AndroidAdb
Condition=" '$(EmbedAssembliesIntoApk)' == 'true' And '$(_UninstallResult)' == 'false' "
ContinueOnError="True"
ToolExe="$(AdbToolExe)"
Expand Down
Loading