-
Notifications
You must be signed in to change notification settings - Fork 2
manage logs for processed and failed messages #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: bota <Bota@dotkernel.com>
| 'eof' => "\n", | ||
| ], | ||
| ], | ||
| 'fail-safe' => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add some comment what is this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are those ? seconds or miliseconds ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Milliseconds
Signed-off-by: bota <Bota@dotkernel.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.0 #30 +/- ##
==========================================
- Coverage 7.69% 5.88% -1.81%
- Complexity 50 95 +45
==========================================
Files 14 16 +2
Lines 221 323 +102
==========================================
+ Hits 17 19 +2
- Misses 204 304 +100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Logged the messages that failed to process. I also created 2 commands which accepts optional flags --start, --end, --limit used to filter by period logs of messages that failed or succeeded in processing.