34029 browser component #34126
Open
34029 browser component #34126
+3,344
−1,071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dit mode support - Updated the title custom field template to support a new edit mode using the `DotCustomFieldApi`. - Implemented event listeners for the title box to automatically update the URL and friendly name fields based on the title input. - Improved code structure by separating logic for new edit mode and legacy Dojo implementation. - Ensured backward compatibility by maintaining the original script for non-edit mode scenarios. This change enhances user experience by providing real-time updates and a more modern approach to handling custom fields.
…template integration
…nd template updates
…:dotCMS/core into 34029-task-migrate-pages-vtls-to-new-api
…:dotCMS/core into 34029-task-migrate-pages-vtls-to-new-api
… from native field component
…roved dialog functionality and styling
…ment, enhance data access with new utility methods
…vice for improved data access
…e and DotTruncatePathPipe to improve modularity
|
Meticulous was unable to execute a test run for this PR because the most recent commit is associated with multiple PRs. To execute a test run, please try pushing up a new commit that is only associated with this PR. Last updated for commit 13bb7af. This comment will update as new commits are pushed. |
10 tasks
|
|
…d components for enhanced dialog management
…d components for enhanced dialog management
…rity and maintainability. Updated mock responses and added tests for contentlet retrieval, locking, and language suggestions. Enhanced test structure with meaningful variable names and consistent use of async patterns.
… improved clarity and maintainability. Updated mock responses and added tests for various upload scenarios, including handling of abort signals and contentlet uploads. Enhanced test structure with meaningful variable names and consistent use of async patterns.
…arity and maintainability. Implemented tests for site and folder retrieval, error handling, and tree structure transformation. Enhanced test structure with meaningful variable names and consistent use of async patterns.
…settings and focus on testing and build targets.
…lderParams for improved type safety and clarity. Updated getContentByFolder method signatures and adjusted related components to streamline content retrieval parameters. Enhanced DotBrowserSelectorComponent to manage folder parameters using Angular's signals for better state management.
…to utilize ContentByFolderParams for improved clarity and type safety. Updated test cases to pass parameters directly, ensuring consistent use of the new structure. Enhanced AngularFormBridge to accept params for better content filtering and retrieval. Streamlined test assertions for better maintainability..
adrianjm-dotCMS
approved these changes
Dec 23, 2025
…s for the DotCustomFieldApi modal. Updated the onClose callback to handle the new URL structure, improving the functionality of the page selection feature.
...c/lib/fields/dot-edit-content-custom-field/components/native-field/native-field.component.ts
Show resolved
Hide resolved
...c/lib/fields/dot-edit-content-custom-field/components/iframe-field/iframe-field.component.ts
Show resolved
Hide resolved
core-web/libs/data-access/src/lib/dot-browsing/dot-browsing.service.ts
Outdated
Show resolved
Hide resolved
…eldComponent, and NativeFieldComponent. Updated return type description and field accessibility notes for clarity and consistency.
dario-daza
reviewed
Dec 24, 2025
dario-daza
approved these changes
Dec 24, 2025
fmontes
requested changes
Dec 24, 2025
fmontes
requested changes
Dec 24, 2025
fmontes
requested changes
Dec 24, 2025
core-web/libs/data-access/src/lib/dot-contentlet/dot-contentlet.service.ts
Show resolved
Hide resolved
…or improved modularity and clarity. Updated service methods to utilize DotCMSAPIResponse for consistent response handling. Enhanced unit tests for DotBrowsingService to ensure robust error handling and folder retrieval functionality.
… 34029-browser-component
…to use providedIn root for improved dependency injection clarity and consistency across services
…gService to enhance modularity and maintainability in the browser store tests and implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request introduces a new
DotBrowsingServicefor browsing sites and folders, refactors several data access services to use consistent API response handling, and adds utility methods for working with file contentlets. The changes improve code consistency, reusability, and support for richer file and folder operations.New browsing functionality
dot-browsing.service.ts, providing methods to retrieve sites and folders as tree nodes, build hierarchical tree structures from paths, and fetch content by folder. This service enables more advanced browsing and selection of site/folder data.DotBrowsingServicein the data access library index for public use.dot-browser-selector.modelto the models index for tree node selection event typing. [1] [2]Refactoring and API consistency
DotContentletServicemethods to use strongly typedDotCMSAPIResponseobjects, improving type safety and consistency. Added support for retrieving contentlet content if editable as a text file, and integrated with the new upload file service methods. [1] [2] [3] [4] [5] [6] [7]DotTagsServiceto use direct HTTP requests, removed dependency onCoreWebService, and added a new method to fetch tags using the v2 API. [1] [2]File upload and content extraction enhancements
DotUploadFileServiceto add methods for uploading assets and automatically extracting text content if the file is editable, streamlining file handling workflows. [1] [2] [3] [4]Checklist