Open
Conversation
added 9 commits
May 24, 2016 15:49
Merge remote-tracking branch 'upstream/master' # Conflicts: # DESCRIPTION
Author
|
I've had a change of heart on the best way to write this function. Using I also rewrote |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hydrophobicityis now vectorized. I also tweaked the data loading code in that function to avoid NOTEs inR CMD check.Removing spaces from sequences is now outsourced to
.remove_spaces(the leading dot to keep it internal). I only used it in thehydrophobicityfunction, but there are a dozen other places where this could be used. Also, I kept the logic as is, but you might want to change the regular expression to"[[:space:]]"to remove other spacing characters like tabs and non-breaking spaces.There is also a small problem with the package licence that I haven't fixed. If you declare GPL-2, you can't also include license file. See section
1.1.2of Writing R Extensions.