fix: remove explicit exclusion of 'claude' clients from tool activation logic. #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mcp-add command was incorrectly skipping tool activation for Claude clients based on the assumption that "Claude clients auto-refresh their tool list". This assumption is incorrect. When mcp-add is called with activate=true, tools were added to g.toolRegistrations (accessible via mcp-exec) but NOT to g.mcpServer (required for native MCP tool calls). This caused: - mcp-add chromedev → success (26 tools registered) - mcp-exec chromedev:list_pages → works (uses toolRegistrations) - native call to chromedev:list_pages → "unknown tool" error The fix removes the Claude client exclusion, allowing updateServerCapabilities() to call g.mcpServer.AddTool() for all clients. Related to docker#278 (tool-name-prefix dispatch fix) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
null-runner
changed the title
null-runner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
mcp-addcommand was incorrectly skipping tool activation for clients with "claude" in their name, based on the assumption that these clients auto-refresh their tool list. This assumption is incorrect.Problem
When
mcp-addis called withactivate=truefrom affected clients:g.toolRegistrations(accessible viamcp-exec)updateServerCapabilities()is never called due to a client name checkg.mcpServer.AddTool()is never executedReproduction:
Root Cause
In
pkg/gateway/mcpadd.goline 234:This check prevents tool activation for any client with "claude" in its name.
Fix
Remove the client name exclusion:
Testing
Tested with Claude Code:
mcp-addRelated
Related to #278 (tool-name-prefix dispatch fix)