Skip to content

fix(Field.Upload): async fileHandler and onFileDelete should work in Iterate.Array#6684

Open
tujoworker wants to merge 4 commits intomainfrom
fix/upload-in-iterate
Open

fix(Field.Upload): async fileHandler and onFileDelete should work in Iterate.Array#6684
tujoworker wants to merge 4 commits intomainfrom
fix/upload-in-iterate

Conversation

@tujoworker
Copy link
Member

@tujoworker tujoworker commented Feb 18, 2026

@tujoworker tujoworker changed the title fix(Field.Upload): async fileHandler and onFileDelete should work in Iterate.Array fix(Field.Upload): async fileHandler and onFileDelete should work in Iterate.Array Feb 18, 2026
@github-actions
Copy link

github-actions bot commented Feb 18, 2026

Branch Preview URL (stable):
https://fix-upload-in-iterate.eufemia-e25.pages.dev

https://fix-upload-in-iterate.eufemia-e25.pages.dev

Deployment URL (unique):
https://c35248b7.eufemia-e25.pages.dev

https://c35248b7.eufemia-e25.pages.dev

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 18, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker requested a review from langz February 18, 2026 11:35
@langz langz changed the title fix(Field.Upload): async fileHandler and onFileDelete should work in Iterate.Array fix(Field.Upload): async fileHandler and onFileDelete should work in Iterate.Array Feb 18, 2026
@langz
Copy link
Contributor

langz commented Feb 18, 2026

I've added a commit containing an example, so that it will be easier to validate in the deploy preview, if the fix works as expected or not.

@langz
Copy link
Contributor

langz commented Feb 18, 2026

Note to self it should work with both Form.Handler with data/defaultData and also with Iterate.Array value.
Form.Handler is most important as that's the use case that's been reported.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 18, 2026

  • eufemia-starter

    yarn add https://pkg.pr.new/dnbexperience/eufemia/@dnb/eufemia@6684.tgz
    

commit: 9a49929

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick test locally, using the stories, but I was still able to experience the same issue as reported:

Screen.Recording.2026-02-18.at.12.56.40.mov

@langz langz force-pushed the fix/upload-in-iterate branch 2 times, most recently from f27ca8c to 2bcbd64 Compare February 18, 2026 12:46
@tujoworker tujoworker force-pushed the fix/upload-in-iterate branch from f86595d to b59744f Compare February 18, 2026 14:38
@tujoworker tujoworker requested a review from langz February 18, 2026 14:39
@tujoworker
Copy link
Member Author

I did a quick test locally, using the stories, but I was still able to experience the same issue as reported:

Nice findings! A new test that fails with the old implementation is added. Also, the fix for this specific issue is inside Iterate.Array.

@tujoworker tujoworker force-pushed the fix/upload-in-iterate branch from b59744f to 9a49929 Compare February 18, 2026 14:48
@langz
Copy link
Contributor

langz commented Feb 18, 2026

I did a quick test locally, using the stories, but I was still able to experience the same issue as reported:

Nice findings! A new test that fails with the old implementation is added. Also, the fix for this specific issue is inside Iterate.Array.

I've tested quite many scenarios and this fix seems to work great 👍
Thanks so much ❤️
Myself and AI was stuck with thinking the fix would be in Upload and/or Field.Upload (#6156) 😓 😂

@langz
Copy link
Contributor

langz commented Feb 18, 2026

Note to self it should work with both Form.Handler with data/defaultData and also with Iterate.Array value. Form.Handler is most important as that's the use case that's been reported.

I’ve not tested both scenarios yet. But only the main scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments