Fix FFmpeg 5.x+ compatibility and macOS build issues#353
Open
ireneYang wants to merge 1 commit intodmlc:masterfrom
Open
Fix FFmpeg 5.x+ compatibility and macOS build issues#353ireneYang wants to merge 1 commit intodmlc:masterfrom
ireneYang wants to merge 1 commit intodmlc:masterfrom
Conversation
|
Try my pull request. It fixes audio, and even adds GPU acceleration to decoding. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes compilation issues on macOS with newer versions of FFmpeg (5.x+). The changes address API incompatibilities and improve the build process for macOS users.
Changes
av_find_best_streamfunction call parameter type for FFmpeg 5.x+Testing
Related Issues
Fixes compilation errors related to:
av_find_best_streamfunction signature changesNotes for Reviewers
These changes primarily focus on compatibility with newer FFmpeg versions while maintaining backward compatibility. The audio support is disabled by default to avoid compilation issues, but can be enabled for environments where it works.