dkms: resolve in-tree certificates to absolute paths #573
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Gentoo, the signing certificate can be obtained from the kernel configuration, which by default is a path relative to it's source directory, causing `prepare_mok` to pass, as the PWD can be within that source directory while checking the obtained paths, but definitely failing during `do_build`, once the PWD is the temporary build directory. This changes the logic to obtain an absolute path using `readlink -f`, instead of assuming that the configured path is absolute
Member
|
Can you fix the tests? https://github.com/dkms-project/dkms/actions/runs/21115333588/job/61133069271?pr=573 You can run the tests with |
Author
|
unless i've missed some extra flags for shellcheck, the tests should now be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Gentoo, the signing certificate can be obtained from the kernel configuration, which by default is a path relative to it's source directory, causing
prepare_mokto pass, as the PWD can be within that source directory while checking the obtained paths, but definitely failing duringdo_build, once the PWD is the temporary build directory.This changes the logic to obtain an absolute path to the certificate using
readlink -f, instead of assuming that the configured path is absolute.