-
-
Notifications
You must be signed in to change notification settings - Fork 108
Fix music bot example #237
base: main
Are you sure you want to change the base?
Conversation
| "extends": "../../tsconfig.json", | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "outDir": "dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already included in the parent tsconfig.json https://github.com/discordjs/voice/blob/main/tsconfig.json#L29
| output: '-', | ||
| quiet: true, | ||
| format: 'bestaudio[ext=webm+acodec=opus+asr=48000]/bestaudio', | ||
| limitRate: '100K', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Types for the flags were added to youtube-dl-exec in this commit.
|
Should probably bump youtube-dl-exec to the latest version. |
|
@almeidx Good call. Updated 👍🏻 |
|
@iCrawl Is this good to go? |
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 73.65% 73.65%
=======================================
Files 21 21
Lines 911 911
Branches 227 221 -6
=======================================
Hits 671 671
Misses 238 238
Partials 2 2 Continue to review full report at Codecov.
|
Fixes for a bunch of Typescript errors in the music bot example.