refactor: move full validation to ChatInputCommandBuilder #11304
+121
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11304 +/- ##
==========================================
+ Coverage 44.97% 45.09% +0.11%
==========================================
Files 317 317
Lines 18222 18259 +37
Branches 1817 1822 +5
==========================================
+ Hits 8196 8233 +37
Misses 10013 10013
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
didinele
approved these changes
Nov 26, 2025
almeidx
force-pushed
the
refactor/validation-on-chatinputcommand
branch
from
2f710d4 to
18c8ae9
Compare
almeidx
force-pushed
the
refactor/validation-on-chatinputcommand
branch
from
18c8ae9 to
4772957
Compare
Qjuh
reviewed
Nov 30, 2025
Comment on lines
+51
to
+52
| const choiceStringPredicate = z.object({ | ||
| ...choiceBasePredicate.shape, |
Member
There was a problem hiding this comment.
what's the reason for not using extend() here and in the following predicates?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #11303
Closes #11308
Made the
chatInputCommandPredicatevalidate the full structure, including options, so users that may be using this predicate can actually validate Chat Input Commands