-
Notifications
You must be signed in to change notification settings - Fork 284
Split ieee_floatt into ieee_float_valuet and ieee_floatt
#8550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2e21587 to
4e6923f
Compare
ieee_floatt into ieee_float_valuet and ieee_floatt
4e6923f to
076e2de
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8550 +/- ##
===========================================
- Coverage 78.85% 77.95% -0.91%
===========================================
Files 1732 1732
Lines 199119 201434 +2315
Branches 18560 18549 -11
===========================================
+ Hits 157023 157035 +12
- Misses 42096 44399 +2303 ☔ View full report in Codecov by Sentry. |
tautschnig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I very much like the idea, but I'm a bit confused: several places (some of which I've commented on below) appear to newly be drawing a rounding mode out of thin air when I'd naively have expected for those to be ieee_float_valuet. Can you please clarify?
076e2de to
8446d05
Compare
8446d05 to
5c8766d
Compare
ac51457 to
be78e50
Compare
This splits ieee_floatt into two parts: 1) ieee_float_valuet stores an IEEE 754 floating-point value. It offers no operations that require rounding, and hence, does not require a rounding mode. 2) ieee_floatt extends ieee_float_valuet with a rounding mode, and hence, offers operators that require rounding.
be78e50 to
d73f9ab
Compare
This splits
ieee_floattinto two parts:ieee_float_valuetstores an IEEE 754 floating-point value. It offers no operations that require rounding, and hence, does not require a rounding mode.ieee_floatt extends
ieee_float_valuetwith a rounding mode, and hence, offers operators that require rounding.