Skip to content

Conversation

@kroening
Copy link
Collaborator

This fixes the flattening of onehot0 expressions.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This fixes the flattening of onehot0 expressions.
@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.61%. Comparing base (fb28475) to head (26505a9).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/flattening/boolbv_onehot.cpp 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8536      +/-   ##
===========================================
+ Coverage    78.59%   78.61%   +0.01%     
===========================================
  Files         1728     1729       +1     
  Lines       199517   199564      +47     
  Branches     18315    18312       -3     
===========================================
+ Hits        156820   156887      +67     
+ Misses       42697    42677      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit 857c88e into develop Dec 19, 2024
39 of 41 checks passed
@tautschnig tautschnig deleted the fix-boolbv-onehot branch December 19, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants