Skip to content

Conversation

@kroening
Copy link
Collaborator

@kroening kroening commented Dec 17, 2024

This documents the existing use of the floatbv_mod and floatbv_rem expressions.

Fixes #8276.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This documents the existing use of the floatbv_mod and floatbv_rem
expressions.
@kroening kroening force-pushed the floatbv-mod-and-rem branch from d8dc00f to 6c2e056 Compare December 17, 2024 17:19
@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.91%. Comparing base (fd13d3a) to head (6c2e056).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8532      +/-   ##
===========================================
- Coverage    78.93%   78.91%   -0.03%     
===========================================
  Files         1728     1728              
  Lines       198634   198698      +64     
  Branches     18309    18449     +140     
===========================================
+ Hits        156795   156796       +1     
- Misses       41839    41902      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening marked this pull request as ready for review December 17, 2024 18:46
Comment on lines +357 to +358
expr_map[ID_floatbv_mod] = binary_infix_expr;
expr_map[ID_floatbv_rem] = binary_infix_expr;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes resolve #8276.

@kroening kroening merged commit 875fbd9 into develop Dec 17, 2024
38 of 41 checks passed
@kroening kroening deleted the floatbv-mod-and-rem branch December 17, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invariant check failed: Condition: expr.operands().size() == 3

3 participants