Skip to content

chore(deps): bump NNS_SNS_REPLICA_REV for self-describing actions#205

Merged
yhabib merged 4 commits intomainfrom
chore/bump-monorepo
Feb 25, 2026
Merged

chore(deps): bump NNS_SNS_REPLICA_REV for self-describing actions#205
yhabib merged 4 commits intomainfrom
chore/bump-monorepo

Conversation

@yhabib
Copy link
Contributor

@yhabib yhabib commented Feb 24, 2026

Motivation

https://github.com/dfinity/snsdemo uses dfx-extensions to set up a local replica. This is utilized by the nns-dapp. The pull request at dfinity/nns-dapp#7742 is blocked by end-to-end tests that depend on snsdemo, as the version of the Governance canister does not include the new API.

Changes

  • Updated NNS_SNS_REPLICA_REV to the latest version to support return_self_describing_action in the Governance canister.
  • Updated dependencies.
  • Updated ledger init to fulfill dfinity/ic@88516cb

@yhabib yhabib requested review from a team as code owners February 24, 2026 15:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the NNS/SNS replica revision and related dependencies to support the new return_self_describing_action API in the Governance canister. This unblocks end-to-end tests in nns-dapp that depend on snsdemo's local replica setup via dfx-extensions.

Changes:

  • Bumped NNS_SNS_REPLICA_REV to 007c473c9c7fc820c49eea5c823cdd4b9404119d for self-describing actions support
  • Updated core dependencies: dfx-core (0.1.2 → 0.3.0), ic-agent/ic-utils (0.40 → 0.45), rust toolchain (1.89.0 → 1.90.0), and dfx (0.29.0 → 0.30.2)
  • Adapted code to API changes including ICP index initialization structure and CanisterInstallMode rename

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
extensions-utils/src/dependencies/dfx.rs Updated NNS_SNS_REPLICA_REV constant to match new IC repository revision
Cargo.toml Updated dfx-core, ic-agent, ic-utils versions and all ic-* git dependencies to new revision; added wirm pinning
rust-toolchain.toml Bumped Rust version from 1.89.0 to 1.90.0
extensions/nns/src/install_nns.rs Updated ICP index initialization to use IndexArg::Init pattern, renamed InstallMode to CanisterInstallMode, reorganized imports
.github/workflows/e2e.yml Updated dfx version from 0.29.0 to 0.30.2 for CI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yhabib yhabib merged commit 2b00a89 into main Feb 25, 2026
10 checks passed
@yhabib yhabib deleted the chore/bump-monorepo branch February 25, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants