chore(deps): bump NNS_SNS_REPLICA_REV for self-describing actions#205
Merged
chore(deps): bump NNS_SNS_REPLICA_REV for self-describing actions#205
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the NNS/SNS replica revision and related dependencies to support the new return_self_describing_action API in the Governance canister. This unblocks end-to-end tests in nns-dapp that depend on snsdemo's local replica setup via dfx-extensions.
Changes:
- Bumped NNS_SNS_REPLICA_REV to
007c473c9c7fc820c49eea5c823cdd4b9404119dfor self-describing actions support - Updated core dependencies: dfx-core (0.1.2 → 0.3.0), ic-agent/ic-utils (0.40 → 0.45), rust toolchain (1.89.0 → 1.90.0), and dfx (0.29.0 → 0.30.2)
- Adapted code to API changes including ICP index initialization structure and CanisterInstallMode rename
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| extensions-utils/src/dependencies/dfx.rs | Updated NNS_SNS_REPLICA_REV constant to match new IC repository revision |
| Cargo.toml | Updated dfx-core, ic-agent, ic-utils versions and all ic-* git dependencies to new revision; added wirm pinning |
| rust-toolchain.toml | Bumped Rust version from 1.89.0 to 1.90.0 |
| extensions/nns/src/install_nns.rs | Updated ICP index initialization to use IndexArg::Init pattern, renamed InstallMode to CanisterInstallMode, reorganized imports |
| .github/workflows/e2e.yml | Updated dfx version from 0.29.0 to 0.30.2 for CI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jasonz-dfinity
approved these changes
Feb 24, 2026
0xFFrancesco
approved these changes
Feb 25, 2026
viviveevee
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/dfinity/snsdemo uses dfx-extensions to set up a local replica. This is utilized by the nns-dapp. The pull request at dfinity/nns-dapp#7742 is blocked by end-to-end tests that depend on snsdemo, as the version of the Governance canister does not include the new API.
Changes
NNS_SNS_REPLICA_REVto the latest version to supportreturn_self_describing_actionin the Governance canister.