Fix velocity validation logic and chrono API misuse#10
Merged
Conversation
Co-authored-by: dfeen87 <158860247+dfeen87@users.noreply.github.com>
Co-authored-by: dfeen87 <158860247+dfeen87@users.noreply.github.com>
Co-authored-by: dfeen87 <158860247+dfeen87@users.noreply.github.com>
Co-authored-by: dfeen87 <158860247+dfeen87@users.noreply.github.com>
Co-authored-by: dfeen87 <158860247+dfeen87@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review and fix bugs found in code
Fix velocity validation logic and chrono API misuse
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two critical bugs identified during code review:
Velocity Validation Logic Error
Impact: Safety monitor rejects all valid positive velocities and most negative velocities
The plausibility check compared velocity components directly against
MIN_VELOCITY_M_S(-20000), rejecting any value above it:Added
MAX_VELOCITY_M_S = 20000.0fconstant toPropulsionPhysicsEngineclass scope for consistency.Chrono API Misuse
Impact: Compilation failure in HIL rig server
Used
steady_clock::now().time_since_epoch()which doesn't exist. Changed tosystem_clockwhich provides epoch-based timestamps.Additional Changes
.gitignorefor build artifacts and IDE files💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.