update to 0.10 #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
tested 🙌🙌 |
Sandertv
reviewed
Jan 25, 2025
Member
Sandertv
left a comment
Sandertv
left a comment
There was a problem hiding this comment.
Most of this looks good. Just have another look at Brush.Use(), which doesn't currently work properly with the world transactions.
Sandertv
reviewed
Jan 26, 2025
brush/brush.go
Outdated
| var bb = cube.Box(-0.125, -0.125, -0.125, 0.125, 0.125, 0.125) | ||
|
|
||
| func (b Brush) Use(p *player.Player) { | ||
| func (b Brush) Use(p *player.Player, h *world.EntityHandle) { |
Member
There was a problem hiding this comment.
This is still not right. Brush.Use() is being called on another goroutine which invalidates *player.Players. Don't pass the player to this function, only pass the handle. You can retrieve the player in the transaction by asserting e: p := e.(*player.Player)
Sandertv
reviewed
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got no clue if this is right at all 😭