[PR Reopen]Changes: fix activation view filling the whole screen in horizontal orientation and some others... #25
Conversation
* Fixed activation view filling the whole screen on horizontal orientation with slightly modified `calculateActivationIndicatorSize`. Instead of using dip
it is now using percentage so that the height in vertical orientation is proportional to the horizontal orientation height
* Added `system gesture exclusion rects` to prevent conflicting with android's back gesture starting Android 10
* Added option to display hint on the activation area
|
you need to do another master merge. I broke the tests yesterday but now they are fixed |
| val exclusionRects = mutableListOf<Rect>() | ||
| val exclusionRect = Rect(0, 0,activationRect.width(), activationRect.height()) | ||
| exclusionRects.add(exclusionRect) | ||
| if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q){ // Android 10 and up | ||
| result.activationView!!.systemGestureExclusionRects = exclusionRects | ||
| } |
|
ok done |
|
Nice. Really thanks for your work! I didn't even think that there is a way to exclude certain areas from the back gesture. Now I can use my own app again on my main phone 🤣 |
I also got that idea from Samsung's Edge Panel, that feature never interfere with the back gesture so got me wondering if there's a function to exclude some parts of the screen to disable system gesture. Turns out there is. |
|
The F-Droid release hasnt been updated since 2018, is there any plan to update it? Or maybe release the prebuilt APK here on github as well? |
|
Ugh apparently, there's a vertical size limit on the So if you set the |
Ok. This means that we have to limit the activation size in that case... |
I missed to push the tags so F-Droid was not triggered. The latest update got picked up and is available on F-Droid: |
2 participants
PR Summary: #24