Skip to content

fix viewportFlipY XOR condition #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CyCle1024 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix viewportFlipY XOR condition #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c9e191
fix viewportFlipY XOR condition
CyCle1024 Jan 27, 2026
0cb8113
simplify XOR in viewportFlipY
CyCle1024 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/dk_device.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ class Device

// Rasterizer expects clip space +Y to point down. In UpperLeft mode with Y pointing up
// (or LowerLeft mode with Y pointing down) we need to flip the incoming Y coordinate.
bool viewportFlipY() const noexcept { return !isYAxisPointsDown() ^ !isOriginLowerLeft(); }
bool viewportFlipY() const noexcept { return isYAxisPointsDown() ^ !isOriginLowerLeft(); }

DkResult initialize() noexcept;
~Device();
Expand Down