new icon: emailjs (original, original-wordmark, plain)#2640
new icon: emailjs (original, original-wordmark, plain)#2640KekMuzaffer wants to merge 2 commits intodevicons:developfrom
Conversation
|
PR is ready for review; please approve workflows and run checks. |
weh
left a comment
There was a problem hiding this comment.
Hi @KekMuzaffer, thank you for your contribution.
i have two points to update.
-
Replace the
plainversion with aplain-wordmarkversion
see my other comment, but basicallyoriginalcan be used as an alias forplainin this case. -
add a empty line to each *.svg file
some Editors need the .svg files to have a empty line at the end.
Also a general tip to work with github repositories. You should keep the main branches (in our case master and develop) unchanged in your repository. If you want to add something, create a feature branch named like "new-icon-foo" or whatever style you like. This makes it easier for you, to update your own repository forks master and develop branch, if you plan to add more icons later.
| "svg": [ | ||
| "original", | ||
| "original-wordmark", | ||
| "plain" |
There was a problem hiding this comment.
The plain file version is not needed here, since the original version is so simple that it can be aliased (one single path, one color).
But a plain-wordmark version would be great. Just copy the original-wordmark file, and merge all paths into a single orange path. Check our Wiki for tips using Inkscape or other tools.
| ] | ||
| }, | ||
| "color": "#ff8434", | ||
| "aliases": [] |
There was a problem hiding this comment.
| "aliases": [] | |
| "aliases": [ | |
| { | |
| "base": "original", | |
| "alias": "plain" | |
| } | |
| ] |
this is how you can use the original file also as plain
Double check these details before you open a PR
developbranch.devicon.jsonfile at the correct alphabetic position as seen hereThis PR closes #845
Link to prove your SVG is correct and up-to-date.
https://www.emailjs.com/