Skip to content

Conversation

@Bulani
Copy link
Contributor

@Bulani Bulani commented Oct 28, 2025

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #2562

Link to prove your SVG is correct and up-to-date.

https://typer.tiangolo.com/
https://github.com/fastapi/typer/blob/master/docs/img/icon.svg

@Bulani
Copy link
Contributor Author

Bulani commented Oct 28, 2025

@weh Can you tag it with Hacktoberfest?

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bulani, thank you for your contribution. To use the icon for the font, it needs to be a single svg path with a single color. so in the current form it is not usable. Check our wiki pages for instructions: Creating Plain Icons

Also the current file should be named typer-original-wordmark.svg. If you find time it should be no big effort to also create a typer-original.svg and typer-plain.svg version by removing the text. This should not be a big thing, and would match most of the existing icon submissions having versions with and without wordmark.

@weh weh added the hacktoberfest Issues we want Hacktoberfest contributors to help with label Oct 31, 2025
@weh
Copy link
Contributor

weh commented Jan 9, 2026

@Bulani, do you need help or have questions about the needed changes?

@weh
Copy link
Contributor

weh commented Jan 21, 2026

@Bulani, i can make the changes myself, but just to be clear, this is not in the spirit of hacktoberfest.

@weh weh added feature:icon PR when a new icon is ready to be added to the collection and removed hacktoberfest Issues we want Hacktoberfest contributors to help with labels Jan 21, 2026
@weh weh self-assigned this Jan 21, 2026
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the open request and added some more versions

@weh weh added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Feb 3, 2026
@weh weh requested review from a team, Snailedlt, canaleal and lunatic-fox and removed request for a team February 3, 2026 11:06
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@weh weh changed the title new icon: typer (original) new icon: typer (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants