Conversation
f9c9eea to
ad28338
Compare
dkwon17
left a comment
There was a problem hiding this comment.
Thank you for the PR, so far, I have a couple of comments
.github/workflows/ubi9-build.yaml
Outdated
| # Setup QEMU for cross-platform builds | ||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v2 | ||
| # Setup Docker Buildx with container driver |
There was a problem hiding this comment.
| # Setup Docker Buildx with container driver |
.github/workflows/ubi9-build.yaml
Outdated
| run: sudo rm -rf /usr/local/lib/android | ||
| - name: Cleanup docker images | ||
| run: docker system prune -af | ||
| # Setup QEMU for cross-platform builds |
There was a problem hiding this comment.
I think these comments don't add much value. I suggest removing them
| # Setup QEMU for cross-platform builds |
.github/workflows/ubi9-build.yaml
Outdated
| # Setup QEMU for cross-platform builds | ||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v2 | ||
| # Setup Docker Buildx with container driver |
There was a problem hiding this comment.
| # Setup Docker Buildx with container driver |
.github/workflows/ubi9-build.yaml
Outdated
| run: sudo rm -rf /usr/local/lib/android | ||
| - name: Cleanup docker images | ||
| run: docker system prune -af | ||
| # Setup QEMU for cross-platform builds |
There was a problem hiding this comment.
| # Setup QEMU for cross-platform builds |
|
@prabhuk25 : Do you think these changes need to be ported for UBI10 too? https://github.com/devfile/developer-images/blob/main/base/ubi10/Dockerfile |
|
@prabhuk25 : It seems build is failing for ppc64le . Do you know if |
|
@rohanKanojia: No, the ubuntu-22.04 GitHub-hosted runner does not have ppc64le emulation enabled by default. So, I have used QEMU to enable explicitly. |
Yeah, it is good to have it for UBI10 as well |
62ce046 to
03f00ca
Compare
b31bc36 to
3824f27
Compare
universal/ubi9/Dockerfile
Outdated
| ENV NODEJS_20_VERSION=20.18.1 | ||
| ENV NODEJS_18_VERSION=18.20.5 | ||
| ENV NODEJS_DEFAULT_VERSION=${NODEJS_20_VERSION} | ||
| ENV NODEJS_DEFAULT_VERSION=${NODEJS_18_VERSION} |
There was a problem hiding this comment.
@prabhuk25 could you please consider creating a separate PR for this change?
|
I'm sorry for the delay @prabhuk25 , could you please rebase your branch against the main branch and force push? |
Refactor installation steps for various tools to support multiple architectures and improve error handling. Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
Updated the GitHub Actions workflow to support multi-architecture builds for UBI 9 base images, including amd64, arm64, and ppc64le. Adjusted the build and publish steps accordingly. Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
Refactor UBI9 build workflow for improved clarity and functionality. Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
Enhanced for ppc64le arch Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
Enhanced for ppc64le arch Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
Signed-off-by: Prabhu K <prabhu.k@ibm.com>
Signed-off-by: Prabhu K <prabhu.k@ibm.com>
Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
871eebf to
36f49f3
Compare
Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
8447e6d to
298d3e3
Compare
Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, prabhuk25 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Enhanced the UBI9 image for ppc64le support and modified the UBI9 build workflow to support ppc64le arch with existing runners.