Open
Conversation
…at do the updateUserStatsForPRT and transferOwnershipAndInject functions do
…ck roles and implementation exapmple
…e roles, add calls to such functions in dependant contract
…er contract addition, add RoleManager tests
…the internal function in the contracts with a role mechanism, add comments to IRoleManager, replace 'only system owner can call...' comments with the corresponding role names, change string formating in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace one main "systemOwner" role in the protocol with a variety of different roles for each contract.
There is a RoleManager contract which stores constants containing those roles' names used accross the protocol, functions to check whether a user has a particular role, functions to grant & revoke roles.
Contracts which implement the roles mechanics have the modifiers which call the RolesManager contract inside the internal functions to check whether a caller has a particular role