Skip to content

Conversation

@sfc-gh-truwase
Copy link
Collaborator

Correctly handle ds_grad_is_ready in ZeRO2

Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
@stas00
Copy link
Collaborator

stas00 commented Feb 3, 2026

Interesting, thanks for finding this, Tunji, so then we don't need the condition at:

if getattr(param, "ds_grad_is_ready", True):

as your added check will prevent it from ever being False at l1084

Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants