-
Notifications
You must be signed in to change notification settings - Fork 4
fix(deps): update dependency pdfkit to ^0.17.0 #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Warning Rate limit exceeded@renovate[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 2 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pdfkit dependency in package.json is upgraded from ^0.13.0 to ^0.17.0. No other files or changes are present in the diff, and there are no modifications to exported or public API signatures. Pre-merge checks✅ Passed checks (3 passed)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================
==========================
🚀 New features to boost your workflow:
|
a92069e to
4753338
Compare
saltenasl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package-lock.json wasn't updated
d6dcf75 to
474e13b
Compare
37d71b6 to
86bc9a5
Compare
86bc9a5 to
815c838
Compare
fa049b2 to
5fac7b6
Compare
85dbb2b to
1708a23
Compare
e5b6a67 to
dc03477
Compare
dc03477 to
5c35e91
Compare
2796a4d to
a322609
Compare
cb5fcce to
d597863
Compare
d597863 to
3fe1e4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & Test
| "pdfkit": "^0.17.0", | ||
| "pidtree": "^0.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
# Check the @types/pdfkit version in package.json
sed -n '2600,2620p' package.json | grep -A 5 -B 5 "@types/pdfkit" || grep "@types/pdfkit" package.jsonRepository: deepnote/vscode-deepnote
Length of output: 490
🏁 Script executed:
# Check if lockfiles exist
ls -la package-lock.json yarn.lock pnpm-lock.yaml 2>/dev/null || echo "No lockfile found"Repository: deepnote/vscode-deepnote
Length of output: 155
🏁 Script executed:
# Get full dependency info around pdfkit
grep -n "pdfkit\|@types/pdfkit" package.jsonRepository: deepnote/vscode-deepnote
Length of output: 229
🌐 Web query:
pdfkit npm changelog 0.13 0.17 breaking changes
💡 Result:
Summary of notable breaking (or potentially breaking) changes between v0.13.0 and v0.17.x of pdfkit:
- Dropped support for older Node.js and older browsers (v0.15.0: "Drop support for Node.js < 18 and for browsers released before 2020"). This can break apps running on older runtimes. [1]
- Removed deprecated PDFDocument#write method (v0.15.0). Code calling .write() must be updated. [1]
- Upgrade of font handling / fontkit: v0.16.0 updates fontkit to 2.0 — this may change font-loading/metrics behaviour and require font-related code adjustments. [1]
- Updated line-breaking library (linebreak → 1.1 in v0.16.0) and fixes to LineWrapper/precision (v0.17.0) — can change text layout/line wrapping in marginal cases. [1]
- Security / dependency updates (crypto-js updates in earlier releases) and internal API/behavioral changes (PDF/A, AcroForms, embedded files, tiling patterns, tables, rotatable text, dynamic sizing) — these add features and also change output semantics; review new PDF/A/AcroForm/table behaviors if you rely on specific PDF structure. [1][2]
Sources:
- PDFKit CHANGELOG (v0.13 → v0.17 entries). [1]
- PDFKit GitHub releases (v0.17.x tags). [2]
If you want, I can extract the exact changelog lines for each version (0.13.0, 0.14.0, 0.15.0, 0.16.0, 0.17.0/0.17.1/0.17.2) and show the precise text.
🏁 Script executed:
# Check git log for this change to see if it's part of current PR
git log --oneline -20 -- package.json | head -10Repository: deepnote/vscode-deepnote
Length of output: 123
🏁 Script executed:
# Check when package-lock.json was last updated
stat package-lock.json | grep ModifyRepository: deepnote/vscode-deepnote
Length of output: 110
🏁 Script executed:
# See if pdfkit version in lockfile is 0.17.0
grep -A 3 '"pdfkit":' package-lock.json | head -10Repository: deepnote/vscode-deepnote
Length of output: 323
🏁 Script executed:
# Search for pdfkit usage in codebase
rg -i "pdfkit|PDFDocument" --type ts --type js -n | head -30Repository: deepnote/vscode-deepnote
Length of output: 1471
🏁 Script executed:
# Check for .write() method calls (removed in 0.15.0)
rg "\.write\(" --type ts --type js -n | grep -i pdf || echo "No .write() calls found"Repository: deepnote/vscode-deepnote
Length of output: 50382
🏁 Script executed:
# Check Node.js version target in tsconfig or package.json
grep -E "(engines|target|node)" package.json tsconfig.json 2>/dev/null | head -20Repository: deepnote/vscode-deepnote
Length of output: 2603
🏁 Script executed:
# Look for any PDF-related code that might use fontkit or advanced features
find . -name "*.ts" -o -name "*.js" | xargs grep -l "pdfkit\|PDFDocument" 2>/dev/null | head -5Repository: deepnote/vscode-deepnote
Length of output: 202
Review pdfkit 0.17 upgrade for breaking changes and type misalignment
pdfkit between 0.13 and 0.17 has several breaking changes: Node.js < 18 dropped (v0.15), PDFDocument#write() removed (v0.15), fontkit upgraded to 2.0 (v0.16), and line-breaking behavior changes (v0.16–0.17). Meanwhile, @types/pdfkit remains at ^0.11.0, creating a 6+ minor version gap with the runtime.
Before merge, verify:
- The codebase doesn't use
PDFDocument#write()or affected font/layout APIs - TypeScript compilation succeeds with the version mismatch
- The plot export workflow (plotViewer.node.ts) produces valid PDFs
3fe1e4b to
e77df08
Compare
This PR contains the following updates:
^0.13.0->^0.17.0Release Notes
foliojs/pdfkit (pdfkit)
v0.17.2Compare Source
v0.17.1Compare Source
[object Object]v0.17.0Compare Source
image()without x and y coordinatesv0.16.0Compare Source
Nameproperty for set custom icon fornote()v0.15.2Compare Source
v0.15.1Compare Source
v0.15.0Compare Source
writemethodv0.14.0Compare Source
Add support for PDF/A-1b, PDF/A-1a, PDF/A-2b, PDF/A-2a, PDF/A-3b, PDF/A-3a
Update crypto-js to v4.2.0 (properly fix security issue)
Add support for EXIF orientation on JPEG images (#626 and #1353)
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit
This is a maintenance release with no user-facing changes.
✏️ Tip: You can customize this high-level summary in your review settings.