fix: return empty list for VASP forward_common_files to prevent upload errors#1811
Draft
fix: return empty list for VASP forward_common_files to prevent upload errors#1811
Conversation
…d errors Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [BUG] _dpgen autotest run error_<work_path>
fix: return empty list for VASP forward_common_files to prevent upload errors
Sep 8, 2025
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical issue where
dpgen autotest runwould fail withRuntimeError: cannot find upload filewhen using VASP as the DFT calculator.Problem
When running
dpgen autotest run relax.json machine.jsonwith VASP configuration, users encountered:This error occurred because:
forward_common_files()method returned["INCAR", "POTCAR"]confs/ZrO2-m/relaxation/) and symlinks them to task directoriesSolution
Modified
VASP.forward_common_files()to return an empty list[]instead of["INCAR", "POTCAR"]. This change:[]for similar reasonsmake_input_file()andmake_potential_files()methodsforward_files()method which correctly returns task-specific filesTesting
forward_files()still returns correct task-specific files:["INCAR", "POSCAR", "KPOINTS", "POTCAR"]Fixes #1139.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.