style: use mdformat to format Markdown#5209
style: use mdformat to format Markdown#5209njzjz wants to merge 7 commits intodeepmodeling:masterfrom
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
Summary of ChangesHello @njzjz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's code style enforcement by standardizing Markdown formatting through the introduction of Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the pre-commit configuration to use mdformat for formatting Markdown files, replacing blacken-docs. This is a positive change, as mdformat offers more extensive formatting capabilities and plugins. However, I've identified a critical issue with the specified version for mdformat that will cause the pre-commit hook to fail. My review includes a suggestion to fix this.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull request overview
Updates the repo’s formatting tooling by switching Markdown formatting in pre-commit from blacken-docs/prettier coverage to mdformat, aiming to standardize Markdown style as part of the project’s lint/format pipeline.
Changes:
- Replace
blacken-docswith anmdformatpre-commit hook plus severalmdformat-*plugins. - Remove Markdown from the
prettierhook’stypes_orso Markdown is handled bymdformat.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
It's currently blocked by executablebooks/mdformat-myst#13 and I have to use a developing version of mdformat-myst.
This reverts commit a3243a1.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5209 +/- ##
==========================================
- Coverage 81.99% 81.99% -0.01%
==========================================
Files 724 724
Lines 73806 73807 +1
Branches 3615 3615
==========================================
- Hits 60520 60519 -1
- Misses 12123 12125 +2
Partials 1163 1163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ```{eval-rst} | ||
| .. dargs:: | ||
| :module: deepmd.utils.argcheck | ||
| :func: gen_args_multi_task | ||
| :module: deepmd.utils.argcheck | ||
| :func: gen_args_multi_task | ||
| ``` |
There was a problem hiding this comment.
No description provided.