Allow using SOPS with PGP, GCP and Azure #228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves `key_check` function to look out for PGP, GCP and Azure environment variables, not just AWS. Also, key checks are removed for decryption operations. Sops is smart enough to figure the keys on its own.
This commit improves and simplifies handling of Sops-encrypted secrets. Instead of using temporary files, and leaving unencrypted data on rendering failures, Forgen now decrypts in-memory.
Author
|
Sorry for the scope creep, I was just using Forge quite actively and noticed that whenever I made a mistake in the encrypted templates, they were left on disk unencrypted. So I decided to add one more commit and improve this in the same PR. On an unrelated note, I'd also like to propose adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I'd like to use Forge with Sops but the current implementation from #181 is limited AWS KMS-only. So, naturally, I'd like to propose a slight improvement.
This PR improves
key_checkfunction to look out for PGP, GCP and Azure environment variables, not just AWS.Also, key checks are removed for decryption (and re-encryption) operations. Sops is smart enough to figure the keys on its own: the encrypted files actually contain all the necessary information. At the very least, just running
sops -d example-enc.ymlwithout any environment variables set is enough to decrypt it, as long as I have the keys, of course.I've tested my changes and they seem to work with my PGP+GCP KMS Sops-encrypted files without any issues.
Thanks!