Add initial support for Dji Osmo Action 1 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Dji Osmo Action 1
Add support for Dji Osmo Action 1
Miniontoby
reviewed
Jul 18, 2025
|
|
||
| export function isDjiDevice(manufacturerData: Buffer): boolean { | ||
| return manufacturerData.subarray(0, 2).equals(djiTechnologyCoLtd); | ||
| return manufacturerData.subarray(0, 2).equals(djiTechnologyCoLtd || manufacturerData.subarray(0, 2).equals(djiTechnologyCoLtd_old); |
There was a problem hiding this comment.
I think you're missing a ) right before the || manufacturerData.subarray..
Also maybe its better to just do this instead to save some performance (not that it really matters, but it is better)
export function isDjiDevice(manufacturerData: Buffer): boolean {
const manufacturerId = manufacturerData.subarray(0, 2);
return manufacturerId.equals(djiTechnologyCoLtd) || manufacturerId.equals(djiTechnologyCoLtd_old);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for Dji Osmo Action 1