Updated error message text when notebook size exceeds 10485760 bytes#292
Open
lcirvin wants to merge 1 commit intodatabrickslabs:masterfrom
Open
Updated error message text when notebook size exceeds 10485760 bytes#292lcirvin wants to merge 1 commit intodatabrickslabs:masterfrom
lcirvin wants to merge 1 commit intodatabrickslabs:masterfrom
Conversation
…xcessively large notebooks
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to download a notebook greater than 10485760 bytes in size, the API previously returned an error formatted as follows:
{"error_code": "BAD_REQUEST", "message": "Size exceeds 10485760 bytes", "http_status_code": 400, "path": "/Users/xxx@xxx.com/xxx"}There appears to have been an update, such that the error is now formatted more along the lines of:
{"error_code": "BAD_REQUEST", "message": "Notebook size exceeded limit: *(some file size)* > 10485760", "http_status_code": 400, "path": "/Users/xxx@xxx.com/xxx"}This PR updates WorkspaceClient.py to account for the update, to restore functionality provided by the
--skip-large-nbflag