AMM: Don't schedule tasks to paused workers#5431
Merged
crusaderky merged 4 commits intodask:mainfrom Oct 20, 2021
Merged
Conversation
5be5309 to
5698018
Compare
05a12e5 to
8bf6b0e
Compare
253d397 to
4c55e9b
Compare
4c55e9b to
df7c9b0
Compare
This was referenced Oct 19, 2021
Collaborator
Author
|
I further broke down this PR. It's now ready for review. |
fjetter
reviewed
Oct 20, 2021
Comment on lines
+5487
to
+5490
| client_msgs: dict = {} | ||
| worker_msgs: dict = {} | ||
| parent._transitions(recs, client_msgs, worker_msgs) | ||
| self.send_all(client_msgs, worker_msgs) |
Member
There was a problem hiding this comment.
Suggested change
| client_msgs: dict = {} | |
| worker_msgs: dict = {} | |
| parent._transitions(recs, client_msgs, worker_msgs) | |
| self.send_all(client_msgs, worker_msgs) | |
| self.transitions(recs) |
Collaborator
Author
There was a problem hiding this comment.
Aren't client_msgs and worker_msgs filled in place by _transitions()? I fell for this already before.
Member
There was a problem hiding this comment.
Yes, if you're using the underscored method, you'll need to call the send yourself. If you use the non-underscored one this will be done. You basically just copied what the non-underscored method does,
distributed/distributed/scheduler.py
Lines 7145 to 7155 in f3aa9d1
Co-authored-by: Florian Jetter <fjetter@users.noreply.github.com>
fjetter
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In scope
Follow-ups
Out of scope