refactor: cleanup DashSpvClient to have single run() entry point#457
Draft
xdustinface wants to merge 3 commits intov0.42-devfrom
Draft
refactor: cleanup DashSpvClient to have single run() entry point#457xdustinface wants to merge 3 commits intov0.42-devfrom
DashSpvClient to have single run() entry point#457xdustinface wants to merge 3 commits intov0.42-devfrom
Conversation
All fields wrapped in `Arc` with locks. Callers hold a handle while the monitoring loop runs in a spawned task via `run()` getting rid of the command channel pattern.
Make monitoring and sync run as tokio tasks instead of dedicated OS threads. This removes the `std::thread::spawn` + `block_on` pattern and uses the existing tokio runtime directly.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Combine `start()` + `monitor_network()` + `stop()` into a single `run(token)` entry point. Callers no longer need to call `start()` separately since `run()` handles the full lifecycle and returns after the token is cancelled. - Make `start()` an internal function - Remove `monitor_network()` its loop is now inside `run()` - Remove `dash_spv_ffi_client_start` so that `dash_spv_ffi_client_run` is the only FFI entry point - Move ctrl-c handling out of the client
xdustinface
force-pushed
the
refactor/client-start-in-run
branch
from
ba63b6a to
1d325f3
Compare
github-actions
bot
added
the
merge-conflict
|
This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine
start()+monitor_network()+stop()into a singlerun(token)entry point. Callers no longer need to callstart()separately sincerun()handles the full lifecycle and returns after the token is cancelled.start()an internal functionmonitor_network()its loop is now insiderun()dash_spv_ffi_client_startso thatdash_spv_ffi_client_runis the only FFI entry pointBased on:
DashSpvClientcloneable #453