Added flushing of reserved modifications, set_value used for initiali…#226
Open
jschmieg wants to merge 4 commits intodaq-db:masterfrom
Open
Added flushing of reserved modifications, set_value used for initiali…#226jschmieg wants to merge 4 commits intodaq-db:masterfrom
jschmieg wants to merge 4 commits intodaq-db:masterfrom
Conversation
gjerecze
reviewed
Jan 15, 2019
gjerecze
left a comment
gjerecze
left a comment
There was a problem hiding this comment.
The performance drop is significant: from 264k to 132k on a single-threaded put. Simple test without drain gives 171k.
lib/pmem/ARTree.cpp
Outdated
| // Temporarily disable the node | ||
| nodeLeafCompressed_new->key = -1; | ||
| pmemobj_flush(_pm_pool.get_handle(), | ||
| &nodeLeafCompressed_new->depth, 2 * sizeof(int)); |
Contributor
Author
There was a problem hiding this comment.
To flush depth and type. Now I changed to separate "flushes".
lib/pmem/ARTree.h
Outdated
| const int PREALLOC_LEVELS = 1; | ||
| // size of table for actions for each Node | ||
| #define ACTION_NUMBER_NODE256 (1 + 256) | ||
| #define ACTION_NUMBER_NODE256 (1 + 256 + 2 * 256) |
There was a problem hiding this comment.
Can we add defines for the magic numbers? It's getting harder to understand which one is used for what.
gjerecze
reviewed
Jan 18, 2019
gjerecze
left a comment
gjerecze
left a comment
There was a problem hiding this comment.
We have further drop in performance to 120K.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…zation of Node child